sync_diff_inspector: use hex to compare blob data#709
sync_diff_inspector: use hex to compare blob data#709erwadba wants to merge 2 commits intopingcap:masterfrom
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
| if data1.IsNull && data2.IsNull { | ||
| if data1.IsNull && data2.IsNull { | ||
| if str1 == str2 { | ||
| continue |
There was a problem hiding this comment.
When data1 and data2 are nil, str1 == str2 is always true?
| if (str1 == str2) && (data1.IsNull == data2.IsNull) { | ||
| continue | ||
| case mysql.TypeJSON: | ||
| var v1, v2 any |
There was a problem hiding this comment.
check whether str1 == str2 first?
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
What problem does this PR solve?
Issue Number: close #710
What is changed and how it works?
Use hex to compare blob data.
Check List
Tests