Skip to content

DNM: playground: Add config 'use-table-id-as-path=true' while creating changefeed for TiCI#2692

Open
yinshuangfei wants to merge 1 commit intopingcap:feature/ftsfrom
yinshuangfei:feature/use_table_id_as_path
Open

DNM: playground: Add config 'use-table-id-as-path=true' while creating changefeed for TiCI#2692
yinshuangfei wants to merge 1 commit intopingcap:feature/ftsfrom
yinshuangfei:feature/use_table_id_as_path

Conversation

@yinshuangfei
Copy link

@yinshuangfei yinshuangfei commented Mar 9, 2026

Add config 'use-table-id-as-path=true' while creating changefeed for TiCI.

What is changed and how it works?

To enable tici to support rebuilding tables with the same name, ticdc supports configuring the path to use the table_id (#4356).

To ensure that changefeed creation uses the table_id as the path when using tici, playground need the use-table-id-as-path=true configuration enabled by default.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from breezewish and kaaaaaaang March 9, 2026 04:28
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2026
@yinshuangfei yinshuangfei changed the title playground: Add config 'use-table-id-as-path=true' while creating changefeed for tici playground: Add config 'use-table-id-as-path=true' while creating changefeed for TiCI Mar 9, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/fts@0acca3f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/cluster/api/cdcapi.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             feature/fts    #2692   +/-   ##
==============================================
  Coverage               ?   46.90%           
==============================================
  Files                  ?      372           
  Lines                  ?    38104           
  Branches               ?        0           
==============================================
  Hits                   ?    17870           
  Misses                 ?    18088           
  Partials               ?     2146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yinshuangfei yinshuangfei changed the title playground: Add config 'use-table-id-as-path=true' while creating changefeed for TiCI DNM: playground: Add config 'use-table-id-as-path=true' while creating changefeed for TiCI Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants