Skip to content

Persist Codex Thinking Level and Fast Mode#1004

Open
maskdotdev wants to merge 3 commits intopingdotgg:mainfrom
maskdotdev:feat/default-thinking-level-setting
Open

Persist Codex Thinking Level and Fast Mode#1004
maskdotdev wants to merge 3 commits intopingdotgg:mainfrom
maskdotdev:feat/default-thinking-level-setting

Conversation

@maskdotdev
Copy link
Contributor

@maskdotdev maskdotdev commented Mar 13, 2026

What Changed

Moved Codex reasoning effort and fast mode from thread local draft state to persisted global last used settings. ChatView, app settings, and composer draft persistence were updated so the composer follows the shared preference across threads and sessions, and the reasoning labels were centralized in one helper.

Why

resolve #384

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included a video for animation/interaction changes

Video

t3code-persist-thinking.mp4

Note

Persist Codex reasoning effort and fast mode as global user preferences

  • Adds defaultCodexReasoningEffort and lastUsedCodexFastMode to AppSettingsSchema so selections survive across threads and sessions.
  • Changes codexFastMode in ComposerThreadDraftState from boolean to boolean | null, where null means "follow global preference" rather than an explicit off.
  • When a user changes reasoning effort or fast mode in the composer, the new value is written to app settings and the per-thread override is cleared (set to null).
  • Centralizes Codex reasoning effort display labels in a new CODEX_REASONING_EFFORT_LABELS export in packages/contracts/src/model.ts; both CodexTraitsPicker and CompactComposerControlsMenu now receive a defaultEffort prop to mark the current global default.
  • Behavioral Change: previously, drafts with codexFastMode === false were treated identically to unset; they are now persisted as an explicit override, and only null signals absence.

Macroscope summarized deb11c8.

@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1e9e42e9-cb2f-4f0c-87a3-40b2699b248b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 13, 2026
@maskdotdev maskdotdev changed the title Persist Codex composer preferences Persist Codex Thinking Level and Fast Mode Mar 13, 2026
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should behave similar to the draft state for model selected

CleanShot.2026-03-12.at.20.59.10.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(settings): ability to change default thinking level

2 participants