Use idiomatic Effect parsing and timeouts#2674
Draft
cursor[bot] wants to merge 4 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Schema.TaggedErrorClassand replaced millisecond timeout constants withDurationvalues.TestClockwith the mockedChildProcessSpawner.Schema.fromJsonStringand per-record Schema validation instead ofJSON.parseand ad-hoc record probing.Why
These are small, focused Effect idiom improvements that make error data serializable, timeout behavior testable, and JSON boundary parsing schema-driven while preserving current behavior.
UI Changes
Not applicable.
Checklist
Note
Replace millisecond number constants with
Durationvalues and add schema-based Windows process parsingDurationvalues in bothtailscale.tsandProcessDiagnostics.ts, and updates allEffect.timeoutOptioncalls accordingly.WindowsProcessRecordschema toProcessDiagnostics.tswithdecodeWindowsProcessJson/decodeWindowsProcessRecordhelpers;parseWindowsProcessRowsnow uses schema decoding and is exported.TailscaleCommandError,TailscaleStatusParseError, andTailscaleUnavailableErrorfromData.TaggedErrortoSchema.TaggedErrorClasswith typed field schemas.probeTailscaleHttpsEndpointcallers must now passtimeout: Duration.Durationinstead oftimeoutMs: number; passingtimeoutMsis silently ignored and the default timeout applies.Macroscope summarized d6bbc5a.