Reduce provider instance dialog rerenders#2675
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
useEffectthat re-derived the instance ID after label/driver changes.perf-recordings/react-component-health/.Why
react-doctorflaggedAddProviderInstanceDialogfor an effect chain and a state value that existed only to drive handlers. The previous flow rendered once for the label/driver update and then rendered again when the effect synchronizedinstanceId. Moving that derivation into the originating handlers keeps the update batched and removes the extra effect-driven render.Manual react-scan/DevTools-hook measurement during label typing:
AddProviderInstanceDialogrender commits.AddProviderInstanceDialogrender commits.UI Changes
No intended visual UI changes.
React-scan recordings with the overlay enabled are included in the branch:
perf-recordings/react-component-health/before-provider-dialog.webmperf-recordings/react-component-health/after-provider-dialog.webmChecklist
Verification:
bun fmtbun lint(passes with existing warnings)bun typecheckbunx react-doctor apps/web --json --full --offline --fail-on nonereact-scan@0.5.6injected into Vite via Playwright recordingsNote
Reduce rerenders in
AddProviderInstanceDialogby replacing state with a refinstanceIdDirtyboolean state with auseRefso toggling it no longer triggers a re-render.useEffectthat auto-derivedinstanceIdon driver/label changes; explicit handlers (updateDriver,updateLabel,updateInstanceId) now handle derivation inline.resetFormandcloseDialoghelpers to centralize form cleanup; the dialog resets on close rather than on open.handleDialogOpenChangeso form state is cleared only when the dialog is closing, not on every open/close toggle.Macroscope summarized 95a569a.