Skip to content

fix(marketing) : marketing showing wrong icons on linux#2696

Open
ruzbyte wants to merge 2 commits into
pingdotgg:mainfrom
ruzbyte:marketing/fix-linux-icons
Open

fix(marketing) : marketing showing wrong icons on linux#2696
ruzbyte wants to merge 2 commits into
pingdotgg:mainfrom
ruzbyte:marketing/fix-linux-icons

Conversation

@ruzbyte
Copy link
Copy Markdown

@ruzbyte ruzbyte commented May 14, 2026

What Changed

  • Added an monochrome SVG Icon for Linux instead of the TuxIcon, since that one didn't render at at all on the download buttons
  • Also used the same SVG on the download page to keep the icon styling in sync, since the used SVG on download.astro is hard to see
  • fixed the icon rendering condition after data-platform is set
  • doing the same for both download buttons on index.astro

Why

When visiting the new marketing page it showed me the mac icon, digging into the page I saw the TuxIcon in place for the dl-icon--linux, that one didn't render on Zen, Helium or Brave on my Linux machine.

Also the following fallback seemed to be to broad:

-  :global(:not([data-platform])) .dl-icon--apple { display: block; } 
+ :global(html:not([data-platform])) .dl-icon--apple { display: block; }

It resulted into the icon not beeing updated after

document.documentElement.dataset.platform = platform.os; // Line 410

Setting that selector to the html-element didn't make it use the apple icon as fallback always.

UI Changes

Hero

before:
image

after:

image

Download

before:

image

after:

image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

(No animation/interaction changes done)


Note

Low Risk
Low risk UI-only change: swaps the Linux SVG used on marketing download CTAs and tightens a CSS fallback selector, with no backend or data-flow impact.

Overview
Fixes Linux icon rendering on the marketing site by replacing the previous Tux/gradient-based Linux artwork with a simplified monochrome currentColor inline SVG on both index.astro (hero + CTA buttons) and download.astro.

Removes the now-unneeded TuxIcon.astro component and narrows the default icon fallback CSS from :global(:not([data-platform])) to :global(html:not([data-platform])) so the icon updates correctly once data-platform is set.

Reviewed by Cursor Bugbot for commit 6146342. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix wrong Linux icons showing on the marketing site

  • Replaces the TuxIcon component with inline 24x24 currentColor SVGs on the download and index pages, fixing incorrect icon rendering on Linux.
  • Fixes the default Apple icon CSS selector from :not([data-platform]) to html:not([data-platform]), so it only hides when the html element itself lacks data-platform rather than any ancestor element.

Macroscope summarized 6146342.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1af21505-72c1-4636-9e60-a5950559045c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels May 14, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4f4a4bf. Configure here.

Comment thread apps/marketing/src/pages/index.astro
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes May 14, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 14, 2026

Approvability

Verdict: Approved

Straightforward visual fix replacing a Linux icon SVG with a different one in the marketing site. Purely presentational change with no runtime logic impact.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp macroscopeapp Bot dismissed their stale review May 14, 2026 15:52

Dismissing prior approval to re-evaluate 6146342

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant