fix(marketing) : marketing showing wrong icons on linux#2696
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4f4a4bf. Configure here.
ApprovabilityVerdict: Approved Straightforward visual fix replacing a Linux icon SVG with a different one in the marketing site. Purely presentational change with no runtime logic impact. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 6146342

What Changed
TuxIcon, since that one didn't render at at all on the download buttonsdownload.astrois hard to seedata-platformis setindex.astroWhy
When visiting the new marketing page it showed me the mac icon, digging into the page I saw the TuxIcon in place for the
dl-icon--linux, that one didn't render on Zen, Helium or Brave on my Linux machine.Also the following fallback seemed to be to broad:
It resulted into the icon not beeing updated after
document.documentElement.dataset.platform = platform.os; // Line 410Setting that selector to the html-element didn't make it use the apple icon as fallback always.
UI Changes
Hero
before:

after:
Download
before:
after:
Checklist
(No animation/interaction changes done)
Note
Low Risk
Low risk UI-only change: swaps the Linux SVG used on marketing download CTAs and tightens a CSS fallback selector, with no backend or data-flow impact.
Overview
Fixes Linux icon rendering on the marketing site by replacing the previous Tux/gradient-based Linux artwork with a simplified monochrome
currentColorinline SVG on bothindex.astro(hero + CTA buttons) anddownload.astro.Removes the now-unneeded
TuxIcon.astrocomponent and narrows the default icon fallback CSS from:global(:not([data-platform]))to:global(html:not([data-platform]))so the icon updates correctly oncedata-platformis set.Reviewed by Cursor Bugbot for commit 6146342. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix wrong Linux icons showing on the marketing site
TuxIconcomponent with inline 24x24currentColorSVGs on the download and index pages, fixing incorrect icon rendering on Linux.:not([data-platform])tohtml:not([data-platform]), so it only hides when thehtmlelement itself lacksdata-platformrather than any ancestor element.Macroscope summarized 6146342.