Use idiomatic Effect primitives in config and SSH readiness#2697
Draft
cursor[bot] wants to merge 1 commit into
Draft
Use idiomatic Effect primitives in config and SSH readiness#2697cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Durationvalues, while only converting to milliseconds at remote-script/log boundaries.Schema.fromJsonStringand model missing/invalid values withOption.Why
This keeps Effect-based code closer to Effect primitives, makes timing policy easier to test with Effect clocks, and removes ad-hoc
JSON.parse/nullhandling from VCS config parsing.UI Changes
Not applicable.
Checklist
Note
Replace numeric millisecond values with Effect
Durationprimitives in SSH tunnel and VCS configDuration-typed constants and parameters in tunnel.ts; callers must now passDurationvalues fortimeout,interval, andprobeTimeouttowaitForHttpReady.VcsProjectConfighelpers in VcsProjectConfig.ts to useOptioninstead of nulls andtry/catch, includingfindConfigPath,parseConfig, andreadConfiguredKind.resolveKindreturns'auto'.waitForHttpReadynow uses an outerEffect.timeoutOptionto bound total duration instead of a fixed retry count, andreadConfiguredKindreturns'auto'on any parse failure with a warning log.Macroscope summarized 6dfcdaa.