Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/desktop/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,16 @@ function configureApplicationMenu(): void {
},
{ role: "editMenu" },
{ role: "viewMenu" },
...(process.platform === "linux"
? [
{
label: "Zoom In Alias",
accelerator: "Ctrl+=",
role: "zoomIn" as const,
visible: false,
},
]
: []),
{ role: "windowMenu" },
Comment on lines +590 to 600
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium src/main.ts:590

The Zoom In Alias menu item is added to the top-level menu template with visible: false, but Electron ignores this property on Linux top-level items. As a result, users see a literal "Zoom In Alias" entry in the menu bar (File Edit View Zoom In Alias Window Help). Place this item inside the View submenu instead, where visible: false is respected.

-    { role: "viewMenu" },
-    ...(process.platform === "linux"
-      ? [
-          {
-            label: "Zoom In Alias",
-            accelerator: "Ctrl+=",
-            role: "zoomIn" as const,
-            visible: false,
-          },
-        ]
-      : []),
-    { role: "windowMenu" },
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file apps/desktop/src/main.ts around lines 590-600:

The `Zoom In Alias` menu item is added to the top-level menu template with `visible: false`, but Electron ignores this property on Linux top-level items. As a result, users see a literal "Zoom In Alias" entry in the menu bar (File Edit View Zoom In Alias Window Help). Place this item inside the View submenu instead, where `visible: false` is respected.

Evidence trail:
1. apps/desktop/src/main.ts lines 590-598 at REVIEWED_COMMIT: shows 'Zoom In Alias' menu item with `visible: false` added to top-level template on Linux
2. Electron issue #8703 (https://github.com/electron/electron/issues/8703): Documents that `visible`/`enabled` properties don't work for top-level menu items, closed as wontfix with explanation about architectural limitation

{
role: "help",
Expand Down