fix: don't restart the app on normal exists in dev runner#986
Merged
juliusmarminge merged 2 commits intopingdotgg:mainfrom Mar 12, 2026
Merged
fix: don't restart the app on normal exists in dev runner#986juliusmarminge merged 2 commits intopingdotgg:mainfrom
juliusmarminge merged 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
size:XS
juliusmarminge
approved these changes
Mar 12, 2026
gabrielMalonso
pushed a commit
to gabrielMalonso/t3code
that referenced
this pull request
Mar 12, 2026
gabrielMalonso
added a commit
to gabrielMalonso/t3code
that referenced
this pull request
Mar 12, 2026
* fix: don't restart the app on normal exists in dev runner (pingdotgg#986) Co-authored-by: Julius Marminge <julius0216@outlook.com> * feat: add fuzzy workspace entry search (pingdotgg#256) Co-authored-by: Julius Marminge <julius0216@outlook.com> * fix: clean up timeout in PlanSidebar to prevent memory leaks (pingdotgg#949) Co-authored-by: hobostay <hobostay@users.noreply.github.com> * fix: Linux icon now shows up (pingdotgg#807) * fix syntax errors from bad merge * fix: add logging for WebSocket errors (pingdotgg#948) Co-authored-by: hobostay <hobostay@users.noreply.github.com> * fix: add error logging for code highlighting failures (pingdotgg#951) * chore: update actions/checkout and actions/github-script (pingdotgg#956) Co-authored-by: Julius Marminge <julius0216@outlook.com> * update project removal copy (pingdotgg#981) * fix pr size workflow * Fix new-thread shortcuts when terminal is focused - move chat-wide key handling into `_chat` route-level shortcut handler - extract reusable `useHandleNewThread` hook and `isTerminalFocused` helper - update browser WS fixture to support `terminalOpen` RPC shape * Fix mod+N new thread flow and terminal split limits - ensure `chat.new` creates a fresh draft after a promoted draft thread - enforce terminal cap per split group (4) while allowing additional terminal groups - refine sidebar row selected/active styling via shared class-name logic and tests * fix(web): add pointer cursor to running stop-generation button (pingdotgg#900) Co-authored-by: Julius Marminge <julius0216@outlook.com> * fix: add missing closing brace in wsTransport connect method The cherry-pick of WebSocket error logging (b6eba33) left a missing closing brace for the connect() method, causing a TS compilation error. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * style: fix formatting in _chat.tsx Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Noah Gregory <noah@wts.dev> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Kiyotaka <maskdotdev@gmail.com> Co-authored-by: Qiaochu Hu <110hqc@gmail.com> Co-authored-by: hobostay <hobostay@users.noreply.github.com> Co-authored-by: Alex Schwartz <alexschwartz01@gmail.com> Co-authored-by: Adam Naji <110662505+Bashamega@users.noreply.github.com> Co-authored-by: Donald Silveira <donaldsilveira@gmail.com> Co-authored-by: 0x1f99d <crazywolf132@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
|
@nmggithub god bless you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
This changes some potentially unexpected behavior. The dev runner should not restart the app if the user intentionally closes it.
Why
Restarting the app on normal exits is potentially unexpected. It also does not happen cleanly. In my work on #968, I've ran into issues where, upon restart, I would encounter two tray icons instead of one. I don't think it's an issue with my code (as I only keep reference), but it may be a macOS bug. Either way, the restarts don't seem to happen cleanly (although that might be a separate fix). Really, this is just a simple behavior change. If the current restart behavior is intended feel free to close this issue.
UI Changes
N/A
Checklist
I included before/after screenshots for any UI changesI included a video for animation/interaction changesNote
Fix dev runner to skip restart on normal (zero-code) app exits
In dev-electron.mjs, the child process exit handler now checks the exit code and signal before scheduling a restart. A restart is only triggered when the process exits abnormally (non-zero exit code or killed by a signal), preventing unnecessary restarts on clean shutdowns during development.
Macroscope summarized 26e14d2.