-
Notifications
You must be signed in to change notification settings - Fork 208
ADD userguide/managingApp/triggering-a-deployment #6400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ADD userguide/managingApp/triggering-a-deployment #6400
Conversation
|
@eeshaanSA PTAL when you get a chance, and let me know if any changes are required. |
Ayushmore1214
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rahulshendre the link for the screenshot of running deployment seems to be broken
|
Also your DCO seems to be failing , make sure to sign that off.... |
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
74c2193 to
39fe99f
Compare
@Ayushmore1214 |
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Show resolved
Hide resolved
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Outdated
Show resolved
Hide resolved
|
@rahulshendre, I have left some suggestions and some comments, so you understand what kind of grammar changes I am looking for, and also understand how the language is supposed to be. PTAL when you have time. :) |
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
Thanks for the suggestions @eeshaanSA |
eeshaanSA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve earlier comments, commit the suggested changes, and improve the newer sections highlighted in this review. Thanks!
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Show resolved
Hide resolved
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Outdated
Show resolved
Hide resolved
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
|
Addressed all the review comments and improved readability. PTAL. |
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Show resolved
Hide resolved
docs/content/en/docs-v1.0.x/user-guide/managing-application/triggering-a-deployment.md
Outdated
Show resolved
Hide resolved
…iggering-a-deployment.md Signed-off-by: Eeshaan Sawant <100678386+eeshaanSA@users.noreply.github.com>
Signed-off-by: rahulshendre <rahulshendre789@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @rahulshendre!
|
@rahulshendre, you can start working on other pages too. I suggest opening draft PRs for each page (copying them as it is), and then start making your changes, so it is easier to see what changed and how. I will help out with some pages too! Let's get everything ready by EOM. Thanks! |
|
@eeshaanSA Thanks! I’ll start opening draft PRs for the remaining pages shortly. |
What this PR does:
File by file commit from the bigger PR - #6345
Adds the “Triggering a deployment” page under User Guide → Managing Application.
Related to #6395
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: