-
Notifications
You must be signed in to change notification settings - Fork 270
[Multi_K8s-Plugin] Add initializer hook for Helm repo and OCI registry auth #6723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mohammedfirdouss
wants to merge
5
commits into
pipe-cd:master
Choose a base branch
from
mohammedfirdouss:feat/multicluster-initializer-hook
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+223
−7
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f07b2d3
[Multi_K8s-Plugin] Add initializer hook for Helm repo and OCI registr…
mohammedfirdouss eaa1f62
Merge branch 'master' into feat/multicluster-initializer-hook
mohammedfirdouss 5b65086
Merge branch 'master' into feat/multicluster-initializer-hook
mohammedfirdouss f03774f
fix: pass Helm registry and repo passwords via stdin instead of CLI args
mohammedfirdouss b4e7754
Merge branch 'master' into feat/multicluster-initializer-hook
mohammedfirdouss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
107 changes: 107 additions & 0 deletions
107
pkg/app/pipedv1/plugin/kubernetes_multicluster/config/plugin.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| // Copyright 2025 The PipeCD Authors. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package config | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
|
|
||
| "github.com/creasty/defaults" | ||
| ) | ||
|
|
||
| type KubernetesPluginConfig struct { | ||
| // List of helm chart repositories that should be added while starting up. | ||
| ChartRepositories []HelmChartRepository `json:"chartRepositories,omitempty"` | ||
| // List of helm chart registries that should be logged in while starting up. | ||
| ChartRegistries []HelmChartRegistry `json:"chartRegistries,omitempty"` | ||
| } | ||
|
|
||
| func (c *KubernetesPluginConfig) UnmarshalJSON(data []byte) error { | ||
| type alias KubernetesPluginConfig | ||
|
|
||
| var a alias | ||
| if err := json.Unmarshal(data, &a); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| *c = KubernetesPluginConfig(a) | ||
| if err := defaults.Set(c); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (c *KubernetesPluginConfig) HTTPHelmChartRepositories() []HelmChartRepository { | ||
| repos := make([]HelmChartRepository, 0, len(c.ChartRepositories)) | ||
| for _, r := range c.ChartRepositories { | ||
| if r.IsHTTPRepository() { | ||
| repos = append(repos, r) | ||
| } | ||
| } | ||
| return repos | ||
| } | ||
|
|
||
| type HelmChartRepositoryType string | ||
|
|
||
| const ( | ||
| HTTPHelmChartRepository HelmChartRepositoryType = "HTTP" | ||
| ) | ||
|
|
||
| type HelmChartRepository struct { | ||
| // The repository type. Only HTTP is supported. | ||
| Type HelmChartRepositoryType `json:"type" default:"HTTP"` | ||
|
|
||
| // Configuration for HTTP type. | ||
| // The name of the Helm chart repository. | ||
| Name string `json:"name,omitempty"` | ||
| // The address to the Helm chart repository. | ||
| Address string `json:"address,omitempty"` | ||
| // Username used for the repository backed by HTTP basic authentication. | ||
| Username string `json:"username,omitempty"` | ||
| // Password used for the repository backed by HTTP basic authentication. | ||
| Password string `json:"password,omitempty"` | ||
| // Whether to skip TLS certificate checks for the repository or not. | ||
| Insecure bool `json:"insecure"` | ||
| } | ||
|
|
||
| func (r *HelmChartRepository) IsHTTPRepository() bool { | ||
| return r.Type == HTTPHelmChartRepository | ||
| } | ||
|
|
||
| // HelmChartRegistryType represents the type of Helm chart registry. | ||
| type HelmChartRegistryType string | ||
|
|
||
| // The registry types that hosts Helm charts. | ||
| const ( | ||
| OCIHelmChartRegistry HelmChartRegistryType = "OCI" | ||
| ) | ||
|
|
||
| // HelmChartRegistry represents the configuration for a Helm chart registry. | ||
| type HelmChartRegistry struct { | ||
| // The registry type. Currently, only OCI is supported. | ||
| Type HelmChartRegistryType `json:"type" default:"OCI"` | ||
|
|
||
| // The address to the Helm chart registry. | ||
| Address string `json:"address"` | ||
| // Username used for the registry authentication. | ||
| Username string `json:"username,omitempty"` | ||
| // Password used for the registry authentication. | ||
| Password string `json:"password,omitempty"` | ||
| } | ||
|
|
||
| // IsOCI checks if the registry is an OCI registry. | ||
| func (r *HelmChartRegistry) IsOCI() bool { | ||
| return r.Type == OCIHelmChartRegistry | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pass the password via stdin?
The command arguments can be read more easily than the stdin from other processes, so it's better to pass the password via stdin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure we can do that, i think the cli arguments wont be effective.