Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/app/pipedv1/plugin/kubernetes/deployment/sync.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func (p *Plugin) executeK8sSyncStage(ctx context.Context, input *sdk.ExecuteStag
}

// TODO: find the way to hold the tool registry and loader in the plugin.
// Currently, we create them every time the stage is executed beucause we can't pass input.Client.toolRegistry to the plugin when starting the plugin.
// Currently, we create them every time the stage is executed because we can't pass input.Client.toolRegistry to the plugin when starting the plugin.
toolRegistry := toolregistry.NewRegistry(input.Client.ToolRegistry())
loader := provider.NewLoader(toolRegistry)

Expand Down
2 changes: 1 addition & 1 deletion pkg/app/pipedv1/plugin/kubernetes/livestate/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func (p *Plugin) GetLivestate(ctx context.Context, _ *kubeconfig.KubernetesPlugi
}

// TODO: find the way to hold the tool registry and loader in the plugin.
// Currently, we create them every time the stage is executed beucause we can't pass input.Client.toolRegistry to the plugin when starting the plugin.
// Currently, we create them every time the stage is executed because we can't pass input.Client.toolRegistry to the plugin when starting the plugin.
toolRegistry := toolregistry.NewRegistry(input.Client.ToolRegistry())

manifests, err := p.loadManifests(ctx, input, cfg.Spec, provider.NewLoader(toolRegistry), input.Logger)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ func (p *Plugin) sync(
}

// TODO: find the way to hold the tool registry and loader in the plugin.
// Currently, we create them every time the stage is executed beucause we can't pass input.Client.toolRegistry to the plugin when starting the plugin.
// Currently, we create them every time the stage is executed because we can't pass input.Client.toolRegistry to the plugin when starting the plugin.
toolRegistry := toolregistry.NewRegistry(input.Client.ToolRegistry())
loader := provider.NewLoader(toolRegistry)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func (p Plugin) GetLivestate(ctx context.Context, _ *sdk.ConfigNone, deployTarge
}

// TODO: find the way to hold the tool registry and loader in the plugin.
// Currently, we create them every time the stage is executed beucause we can't pass input.Client.toolRegistry to the plugin when starting the plugin.
// Currently, we create them every time the stage is executed because we can't pass input.Client.toolRegistry to the plugin when starting the plugin.
toolRegistry := toolregistry.NewRegistry(input.Client.ToolRegistry())

liveStates := make([]sdk.ApplicationLiveState, 0, len(targetConfigs))
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/application.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ type GenericApplicationSpec struct {

type DeploymentPlanner struct {
// Disable auto-detecting to use QUICK_SYNC or PROGRESSIVE_SYNC.
// Always use the speficied pipeline for all deployments.
// Always use the specified pipeline for all deployments.
AlwaysUsePipeline bool `json:"alwaysUsePipeline"`
// Automatically reverts all deployment changes on failure.
// Default is true.
Expand Down
2 changes: 1 addition & 1 deletion pkg/configv1/application.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ type GenericApplicationSpec struct {

type DeploymentPlanner struct {
// Disable auto-detecting to use QUICK_SYNC or PROGRESSIVE_SYNC.
// Always use the speficied pipeline for all deployments.
// Always use the specified pipeline for all deployments.
AlwaysUsePipeline bool `json:"alwaysUsePipeline"`
// Automatically reverts all deployment changes on failure.
// Default is true.
Expand Down
Loading