[Multi_K8s-Plugin] Add per-target kustomizeVersion and kustomizeOptions#6749
Open
mohammedfirdouss wants to merge 2 commits intopipe-cd:masterfrom
Open
Conversation
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
29b8d04 to
740f3e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Adds
kustomizeVersionandkustomizeOptionsas per-target overrides inside eachmultiTargetsentry inKubernetesMultiTarget, bringing the config schema closer to the RFC-0014 spec.Previously,
kustomizeVersionandkustomizeOptionswere only available at the top-levelspec.input, meaning all targets had to share the same kustomize version and options. This is a problem when deploying to clusters with different kustomize version requirements or different per-cluster flags (e.g.load-restrictor).With this change, users can override these per target:
The override logic follows the same pattern already used for
manifestsinloadManifests: the per-target value is used when non-empty, otherwise the top-levelspec.inputvalue is used.Which issue(s) this PR fixes:
Part of #6446
How was this tested:
Unit tests added to
deployment/load_manifests_test.gousing a capturing mock loader that records theLoaderInputpassed to it, covering:nilmultiTarget falls back to top-level values