[Multi_K8s-Plugin] Add per-stage multiTarget filtering#6757
Open
mohammedfirdouss wants to merge 1 commit intopipe-cd:masterfrom
Open
[Multi_K8s-Plugin] Add per-stage multiTarget filtering#6757mohammedfirdouss wants to merge 1 commit intopipe-cd:masterfrom
mohammedfirdouss wants to merge 1 commit intopipe-cd:masterfrom
Conversation
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
eae0e55 to
843c84f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6757 +/- ##
==========================================
+ Coverage 29.33% 37.52% +8.19%
==========================================
Files 598 94 -504
Lines 63902 7677 -56225
==========================================
- Hits 18744 2881 -15863
+ Misses 43711 4651 -39060
+ Partials 1447 145 -1302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Allows each pipeline stage in the
kubernetes_multiclusterplugin to declare which deploy targets it applies to via amultiTargetslist in the stage options. If the list is empty the stage applies to all targets as before, so existing configs are unaffected.Without this, every stage always runs on all targets. Users cannot do progressive multi-cluster delivery like canary to one cluster first, wait for approval, then roll out to others.
With this change:
Which issue(s) this PR fixes:
Part of #6446
How was this tested:
TestFilterStageTargetstodeployment/misc_test.gowith 5 cases: empty filter returns all targets, single target selected, multiple targets selected, unknown target name silently ignored, mix of known and unknown names.