Upgrade bazel to v6.5.0, upgrade protobuf, tensorflow and dependent deps#2290
Merged
ddelnano merged 17 commits intopixie-io:mainfrom Dec 16, 2025
Merged
Conversation
8ef72cf to
ff0ed38
Compare
2 tasks
a958b02 to
1d098bb
Compare
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com> (cherry picked from commit f69b9d17010abe2cd8cabea7c42a4d4cc5f46f91)
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com> (cherry picked from commit 929b042996c0fa13871d0d3764e1e82a7bfd45fe)
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
1d098bb to
9b80f0a
Compare
ddelnano
commented
Dec 12, 2025
| #else | ||
| constexpr uint64_t kFileSizeLimitMB = 310; | ||
| constexpr uint64_t kFileSizeLimitMB = 325; | ||
| #endif |
Member
Author
There was a problem hiding this comment.
The stirling_wrapper binary size exceeds the previous limit from protobuf v27 and later. I tried to split out a smaller version of this into and the stirling specific changes (the absl upgrade results in the src/stirling/source_connectors/socket_tracer/uprobe_manager.h change) in #2296.
Unfortunately these dependencies have hard dependencies on each other, which makes it hard to do without upgrading all of them.
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
commented
Dec 12, 2025
|
|
||
| #include <map> | ||
| #include <memory> | ||
| #include <mutex> |
Member
Author
There was a problem hiding this comment.
After upgrading absl, the #include <absl/synchronization/mutex.h> on line 27 caused the following failure for the gcc build:
root@px-dev-docker-hacksaw:/px/src/px.dev/pixie# bazel build --config gcc src/stirling/source_connectors/socket_tracer:cc_library
INFO: Analyzed target //src/stirling/source_connectors/socket_tracer:cc_library (23 packages loaded, 170 targets configured).
INFO: Found 1 target...
ERROR: /px/src/px.dev/pixie/src/stirling/source_connectors/socket_tracer/BUILD.bazel:21:14: Compiling src/stirling/source_connectors/socket_tracer/uprobe_manager.cc failed: (Exit 1): gcc-12 failed: error executing command (from target //src/stirling/source_connectors/socket_tracer:cc_library) /usr/bin/gcc-12 -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -fno-omit-frame-pointer '-std=c++17' -MD -MF ... (remaining 330 arguments skipped)
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from src/stirling/source_connectors/socket_tracer/uprobe_manager.cc:19:
./src/stirling/source_connectors/socket_tracer/uprobe_manager.h:608:8: error: 'mutex' in namespace 'std' does not name a type
608 | std::mutex deploy_uprobes_mutex_;
| ^~~~~
./src/stirling/source_connectors/socket_tracer/uprobe_manager.h:44:1: note: 'std::mutex' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
43 | #include "src/stirling/utils/proc_tracker.h"
+++ |+#include <mutex>
44 |
src/stirling/source_connectors/socket_tracer/uprobe_manager.cc: In member function 'void px::stirling::UProbeManager::DeployUProbes(const absl::lts_20250512::flat_hash_set<px::md::UPID>&)':
src/stirling/source_connectors/socket_tracer/uprobe_manager.cc:1010:14: error: 'lock_guard' in namespace 'std' does not name a template type
1010 | const std::lock_guard<std::mutex> lock(deploy_uprobes_mutex_);
| ^~~~~~~~~~
src/stirling/source_connectors/socket_tracer/uprobe_manager.cc:43:1: note: 'std::lock_guard' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
42 | #include "src/stirling/utils/linux_headers.h"
+++ |+#include <mutex>
43 | #include "src/stirling/utils/proc_path_tools.h"
Target //src/stirling/source_connectors/socket_tracer:cc_library failed to build
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
vihangm
approved these changes
Dec 15, 2025
NickLanam
approved these changes
Dec 15, 2025
Member
NickLanam
left a comment
There was a problem hiding this comment.
Rubber stamping for the trivial UI changes
oazizi000
approved these changes
Dec 16, 2025
ddelnano
added a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
…eps (pixie-io#2290) Summary: Upgrade Bazel from 6.2.0 to 6.5.0 along with protobuf, tensorflow, and related dependencies. This is a coordinated upgrade since these dependencies have hard interdependencies that make incremental upgrades difficult. Key changes - Upgrade Bazel from 6.2.0 to 6.5.0 (required by these new dependencies) - Protobuf upgrade with compatibility patches for text format handling and JavaScript generation - TensorFlow upgrade with patches to disable GPU/LLVM/Python features. The GPU disable patch will not be necessary as TensorFlow's fallback logic will work with Bazel 7 - gRPC-web upgrade to 2.0.2 and replacement of the vendored `protoc-gen-grpc-web` with a Bazel repository - Flatbuffers patched to remove rules_js dependency (this upgrade is required by TensorFlow v2.20.0) - absl upgrade (causes transitive header changes) - Regenerated TypeScript protobuf bindings for the UI I attempted to split this into a smaller change in pixie-io#2296. TensorFlow has a tight dependency on protobuf, which prevented that attempt from working. I'm open to other ideas on how to split this up, but so far this seemed like the best balance with pixie-io#2293 and pixie-io#2297 to follow to complete the Bazel 7 migration. Relevant Issues: pixie-io#2282 Type of change: /kind cleanup Test Plan: Build passes --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
added a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
…eps (pixie-io#2290) Summary: Upgrade Bazel from 6.2.0 to 6.5.0 along with protobuf, tensorflow, and related dependencies. This is a coordinated upgrade since these dependencies have hard interdependencies that make incremental upgrades difficult. Key changes - Upgrade Bazel from 6.2.0 to 6.5.0 (required by these new dependencies) - Protobuf upgrade with compatibility patches for text format handling and JavaScript generation - TensorFlow upgrade with patches to disable GPU/LLVM/Python features. The GPU disable patch will not be necessary as TensorFlow's fallback logic will work with Bazel 7 - gRPC-web upgrade to 2.0.2 and replacement of the vendored `protoc-gen-grpc-web` with a Bazel repository - Flatbuffers patched to remove rules_js dependency (this upgrade is required by TensorFlow v2.20.0) - absl upgrade (causes transitive header changes) - Regenerated TypeScript protobuf bindings for the UI I attempted to split this into a smaller change in pixie-io#2296. TensorFlow has a tight dependency on protobuf, which prevented that attempt from working. I'm open to other ideas on how to split this up, but so far this seemed like the best balance with pixie-io#2293 and pixie-io#2297 to follow to complete the Bazel 7 migration. Relevant Issues: pixie-io#2282 Type of change: /kind cleanup Test Plan: Build passes --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Upgrade Bazel from 6.2.0 to 6.5.0 along with protobuf, tensorflow, and related dependencies. This is a coordinated upgrade since these dependencies have hard interdependencies that make incremental upgrades difficult.
Key changes
protoc-gen-grpc-webwith a Bazel repositoryI attempted to split this into a smaller change in #2296. TensorFlow has a tight dependency on protobuf, which prevented that attempt from working. I'm open to other ideas on how to split this up, but so far this seemed like the best balance with #2293 and #2297 to follow to complete the Bazel 7 migration.
Relevant Issues: #2282
Type of change: /kind cleanup
Test Plan: Build passes