Skip to content

Use correct platform for container_push pusher binary #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddelnano merged 1 commit into from
May 15, 2026
+27 −1
Merged

Use correct platform for container_push pusher binary #2372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions bazel/external/rules_docker_pusher_cfg.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
diff --git a/container/push.bzl b/container/push.bzl
index baef9c2..942741d 100644
--- a/container/push.bzl
+++ b/container/push.bzl
@@ -205,7 +205,7 @@ container_push_ = rule(
),
"_pusher": attr.label(
default = "//container/go/cmd/pusher",
- cfg = "target",
+ cfg = "exec",
executable = True,
allow_files = True,
),
diff --git a/contrib/push-all.bzl b/contrib/push-all.bzl
index c7e7f72..fd6518b 100644
--- a/contrib/push-all.bzl
+++ b/contrib/push-all.bzl
@@ -126,7 +126,7 @@ container_push = rule(
),
"_pusher": attr.label(
default = Label("//container/go/cmd/pusher"),
- cfg = "target",
+ cfg = "exec",
executable = True,
allow_files = True,
),
2 changes: 1 addition & 1 deletion bazel/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def _pl_deps():
_bazel_repo("rules_foreign_cc")
_bazel_repo("io_bazel_rules_k8s")
_bazel_repo("io_bazel_rules_closure")
_bazel_repo("io_bazel_rules_docker", patches = ["//bazel/external:rules_docker.patch", "//bazel/external:rules_docker_arch.patch"], patch_args = ["-p1"])
_bazel_repo("io_bazel_rules_docker", patches = ["//bazel/external:rules_docker.patch", "//bazel/external:rules_docker_arch.patch", "//bazel/external:rules_docker_pusher_cfg.patch"], patch_args = ["-p1"])
_bazel_repo("rules_python")
_bazel_repo("rules_pkg")
_bazel_repo("com_github_bazelbuild_buildtools")
Expand Down
Loading