Skip to content

Flexible request body parser#434

Open
tokuhirom wants to merge 4 commits intoplack:masterfrom
tokuhirom:flexble-parser-without-http-body
Open

Flexible request body parser#434
tokuhirom wants to merge 4 commits intoplack:masterfrom
tokuhirom:flexble-parser-without-http-body

Conversation

@tokuhirom
Copy link
Copy Markdown
Member

No description provided.

- It's 100% compatible with older versions.
- User can add any body parser by himself.
- HTTP::MultiPartParser & URL::Encode is faster than HTTP::Body.
- Remove backward compatible layer for HTTP::Body.
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 1fac96a on tokuhirom:flexble-parser-without-http-body into f168ddc on plack:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.78%) when pulling 1fac96a on tokuhirom:flexble-parser-without-http-body into f168ddc on plack:master.

Comment thread lib/Plack/BodyParser/JSON.pm Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really need these?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. My vim snippet injected this. I removed this at 4a80f4e.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.77%) when pulling 4a80f4e on tokuhirom:flexble-parser-without-http-body into f168ddc on plack:master.

@miyagawa
Copy link
Copy Markdown
Member

I saw http://search.cpan.org/~kazeburo/HTTP-Entity-Parser-0.12/lib/HTTP/Entity/Parser.pm and would love to replace HTTP::Body with a faster implementation like this. Is it still viable to update and merge this? cc @kazeburo

See also: @chansen's URL::Encode::XS, HTTP::MessageParser and HTTP::MultipartParser.

cc @avar

@miyagawa
Copy link
Copy Markdown
Member

Duh, I completely forgot this PR and re-implemented everything with #537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants