Flexible request body parser#434
Open
tokuhirom wants to merge 4 commits intoplack:masterfrom
Open
Conversation
- It's 100% compatible with older versions. - User can add any body parser by himself. - HTTP::MultiPartParser & URL::Encode is faster than HTTP::Body.
- Remove backward compatible layer for HTTP::Body.
Member
Author
There was a problem hiding this comment.
Oops. My vim snippet injected this. I removed this at 4a80f4e.
Member
|
I saw http://search.cpan.org/~kazeburo/HTTP-Entity-Parser-0.12/lib/HTTP/Entity/Parser.pm and would love to replace HTTP::Body with a faster implementation like this. Is it still viable to update and merge this? cc @kazeburo See also: @chansen's URL::Encode::XS, HTTP::MessageParser and HTTP::MultipartParser. cc @avar |
Member
|
Duh, I completely forgot this PR and re-implemented everything with #537 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.