Draft
Conversation
On-behalf-of: SAP aleh.yarshou@sap.com
On-behalf-of: SAP aleh.yarshou@sap.com
On-behalf-of: SAP aleh.yarshou@sap.com
On-behalf-of: SAP aleh.yarshou@sap.com
On-behalf-of: SAP aleh.yarshou@sap.com
On-behalf-of: SAP aleh.yarshou@sap.com
On-behalf-of: SAP aleh.yarshou@sap.com
On-behalf-of: SAP aleh.yarshou@sap.com
On-behalf-of: SAP aleh.yarshou@sap.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-behalf-of: SAP aleh.yarshou@sap.com
This pr resolves this issue #228
Changes:
APIExportPolicyresourceauthorization.platform-mesh.ioapiexport.authorization.platform-mesh.ioapiBinding and we decided to haveauthorization.platform-mesh.ioapiBinding only in platform-mesh-system workspaceProcess function flow:
bind,bind_inherited) and workspace path (root:orgs:A) for future client creationroot:orgs:*we need to get cluster ID for every organization workspace, for this we can use allClient and list every accountInfo resource withtype=orgfilter. It's convenient because in accountInfo resource we have all needed information (StoreID,clusterID)root:orgs:*, it means that this is workspace has accountInfo resource. Controller fetches accountInfo resource to get (StoreID,clusterID) information and after creates tuples.For finalization logic is the same, only tuples are being deleted.
This approach has a downside in extra tuples creation terms.
If somebody creates a resource with these expressions:
OpenFGA will have a bunch of pointless tuples, because binding permissions were granted for every workspace by this expression
:root:orgs:*and the rest of the expressions are redundant. But expressions validation should be addressed on validating webhook level.