Skip to content

fix: adding dhcp search for no ip#1481

Merged
spai-p9 merged 2 commits intomainfrom
feature/dhcp-alignment-for-no-ip
Mar 2, 2026
Merged

fix: adding dhcp search for no ip#1481
spai-p9 merged 2 commits intomainfrom
feature/dhcp-alignment-for-no-ip

Conversation

@sanya-pf9
Copy link
Copy Markdown
Contributor

What this PR does / why we need it

VM was DHCP-only before migration.
During migration, no IP was detected for the NIC.
As part of PR #1340, the interface was renamed to vjb1 and configured as inet manual.
This disabled DHCP, so the VM booted with the NIC up but no IPv4 address or routes.

DHCP-only VMs hit the “no IP found” path, which sets the interface to manual and prevents DHCP from running.

Hence, default to inet dhcp when no IP is detected, instead of manual.

fixes #1479

Copy link
Copy Markdown
Contributor

@windsurf-bot windsurf-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

@sanya-pf9
Copy link
Copy Markdown
Contributor Author

On Hold, maybe is resolved with new PCD version

Copy link
Copy Markdown
Collaborator

@spai-p9 spai-p9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spai-p9 spai-p9 enabled auto-merge (squash) March 2, 2026 06:18
@spai-p9 spai-p9 merged commit ed19d30 into main Mar 2, 2026
12 checks passed
@spai-p9 spai-p9 deleted the feature/dhcp-alignment-for-no-ip branch March 2, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Centos7 and Rocky9 is not getting IP inside VM post migration (DHCP IP is there pre migration)

2 participants