Start recording subscription changes in audit trail#6196
Closed
Start recording subscription changes in audit trail#6196
Conversation
|
Contributor
Author
|
We are not going to do it this way, because audit trail might then contain duplicate entries due to webhook retries. This in turn leads to unreliable data. It might be ok for aggregate, statistical queries but not for any sort of book keeping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR instruments all spots where the subscription is either created or updated with an audit trail. The entries will appear under "Audit" tab in our CRM. They can also serve as a better basis to gather aggregate statistics of changes in subscriptions (upgrades, downgrades, etc.).
Tests