Fix: formatted text rendered as visible HTML tags in PDF exports#69
Draft
Rom1-B wants to merge 1 commit into
Draft
Fix: formatted text rendered as visible HTML tags in PDF exports#69Rom1-B wants to merge 1 commit into
Rom1-B wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
GLPI-encoded content (
<p>) was concatenated with the HTML label beforegetEnhancedHtml()processing indisplayText(). The mixed string causedSanitizer::isHtmlEncoded()to return false (literal<>in the label), skipping entity decoding. TCPDF then rendered<p>as visible text characters<p>instead of HTML paragraph tags, producing HTML fragments in the PDF and all text as a single unformatted block.Fix: process
$contentseparately throughgetEnhancedHtml()before concatenating with the label. Also strips residual<script>tags to prevent JavaScript code (e.g., from GLPI's "read more" wrapper) from appearing as visible text in the PDF.Screenshots (if appropriate):