Refine Dutch translations in nl.json #997
Conversation
Updated various Dutch translations for consistency and accuracy.
WalkthroughThis pull request updates Dutch translations in the Plugwise custom component. Changes include grammar corrections, hyphenation standardization, spelling consistency, and punctuation refinements to align with Dutch language conventions. No functional code or logic modifications are present. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI Agents
In @custom_components/plugwise/translations/nl.json:
- Line 328: The Dutch translation at exceptions.response_error contains an
incorrect hyphenated fragment ("of -foutmelding ontvangen"); update the string
to match the config.error.response_error phrasing or one of the suggested
alternatives for consistency—e.g., replace the value for
exceptions.response_error ("Ongeldige XML-data, of -foutmelding ontvangen van de
Plugwise Adam/Smile/Stretch") with either "Ongeldige XML-data, of foutmelding
ontvangen van de Plugwise Adam/Smile/Stretch", "Ongeldige XML-data, of een
XML-foutmelding ontvangen van de Plugwise Adam/Smile/Stretch", or "Ongeldige
XML-data, of XML-foutmelding ontvangen van de Plugwise Adam/Smile/Stretch" so it
follows Dutch conventions and matches config.error.response_error.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
custom_components/plugwise/translations/nl.json
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CoMPaTech
Repo: plugwise/plugwise-beta PR: 0
File: :0-0
Timestamp: 2025-01-25T20:42:24.862Z
Learning: The linting rules in plugwise-beta have been updated to use TC001/TC002/TC003 instead of TCH001/TCH002/TCH003 for type-checking related rules.
📚 Learning: 2025-01-25T20:42:24.862Z
Learnt from: CoMPaTech
Repo: plugwise/plugwise-beta PR: 0
File: :0-0
Timestamp: 2025-01-25T20:42:24.862Z
Learning: The linting rules in plugwise-beta have been updated to use TC001/TC002/TC003 instead of TCH001/TCH002/TCH003 for type-checking related rules.
Applied to files:
custom_components/plugwise/translations/nl.json
🔇 Additional comments (3)
custom_components/plugwise/translations/nl.json (3)
6-53: Configuration translations improved for consistency.The changes in the configuration section properly apply Dutch language conventions:
- Lowercase "opties" for common nouns
- Hyphenation of compound terms (Smile/Stretch-opties, Homekit-emulatie, Plugwise-Zigbeenetwerk)
- Proper compound words (Poortnummer, Netwerkverbindingstimeout)
- Consistent hyphenation of brand names with descriptive terms (Plugwise-apparaat, Smile-ID, XML-data)
60-276: Excellent systematic correction of entity names.The changes systematically correct Dutch spelling and improve consistency across all entity names:
- Spelling correction: "electriciteit" → "elektriciteit" (correct Dutch spelling) applied consistently across ~30 sensor names
- Compound words: Proper formation (Batterijstatus, Elektriciteitsgebruik, Elektriciteitsopwek)
- Hyphenation: Consistent application (Plugwise-melding, Gateway-modus, Zone-profiel)
This significantly improves the user-facing translations in Home Assistant.
339-340: Services translations properly updated.The hyphenation of "Plugwise-notificatie" is consistent with other brand name compounds throughout the file (Plugwise-melding, Plugwise-apparaat, etc.).
| }, | ||
| "response_error": { | ||
| "message": "Ongeldige XML data, of foutmelding ontvangen van de Plugwise Adam/Smile/Stretch" | ||
| "message": "Ongeldige XML-data, of -foutmelding ontvangen van de Plugwise Adam/Smile/Stretch" |
There was a problem hiding this comment.
Review the hyphen prefix in error message.
The construction "of -foutmelding" on line 328 is grammatically unusual in Dutch. The hyphen prefix before "foutmelding" doesn't follow standard Dutch conventions.
This message appears in two places:
- Line 45 (config.error.response_error):
"of foutmelding ontvangen" - Line 328 (exceptions.response_error):
"of -foutmelding ontvangen"
Consider one of these alternatives for consistency and clarity:
- Keep it simple:
"of foutmelding ontvangen"(matches line 45) - Be more specific:
"of een XML-foutmelding ontvangen" - Or if emphasizing the compound:
"of XML-foutmelding ontvangen"
🤖 Prompt for AI Agents
In @custom_components/plugwise/translations/nl.json at line 328, The Dutch
translation at exceptions.response_error contains an incorrect hyphenated
fragment ("of -foutmelding ontvangen"); update the string to match the
config.error.response_error phrasing or one of the suggested alternatives for
consistency—e.g., replace the value for exceptions.response_error ("Ongeldige
XML-data, of -foutmelding ontvangen van de Plugwise Adam/Smile/Stretch") with
either "Ongeldige XML-data, of foutmelding ontvangen van de Plugwise
Adam/Smile/Stretch", "Ongeldige XML-data, of een XML-foutmelding ontvangen van
de Plugwise Adam/Smile/Stretch", or "Ongeldige XML-data, of XML-foutmelding
ontvangen van de Plugwise Adam/Smile/Stretch" so it follows Dutch conventions
and matches config.error.response_error.
There was a problem hiding this comment.
@coderabbitai would the use of the hyphen prefix be correct when the comma is removed?
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Dutch grammar hyphen prefix shared compound words "of -" construction
💡 Result:
Do you mean the suspended‑hyphen construction where two or more words share a common part (e.g. vis- en vleesproducten) or something else? If you can give one or two example phrases you have in mind (like "soja- of maïszetmeel" or "tweede- of derdeklasser"), I’ll explain the correct hyphenation rule and show the right forms with sources.
🌐 Web query:
opschortend koppelteken Dutch suspended hyphen rules examples
💡 Result:
"Opschortend koppelteken" (ook: weglatingsstreepje of samentrekking) gebruik je wanneer je een gedeeld deel van twee of meer samenstellingen weglaat en dat vervangt door een koppelteken. Regels en korte voorbeelden:
- Functie: geeft aan dat een woorddeel is weggelaten (lees: X- en Y→ X en Y waar het tweede deel hetzelfde is). [1]
- Vorm: geen spatie vóór of ná het streepje binnen het woorddeel (bij samentrekking: voor- en nadelen). [1][2]
- Voorbeelden:
- voor- en nadelen (voordelen en nadelen). [1][3]
- jongens- en meisjesboeken (jongensboeken en meisjesboeken). [1][3]
- zon- en feestdagen (zondagen en feestdagen). [1]
- technische, ICT- en communicatiespecialisten (technische specialisten, ICT-specialisten en communicatiespecialisten). [1]
- Let op: je gebruikt geen streepje als er een heel zelfstandig naamwoord wordt weggelaten dat elders staat (bv. "de witte en de bruine schoenen" → geen streepje). [2]
Bronnen: Taalwinkel (UvA/HvA) [1], Vlaanderen.team‑taaladvies (spellingregels samentrekking) [2], NLS Online (uitleg samentrekking/koppelteken) [3].
@bouwew No, the hyphen prefix would still not be correct without the comma.
The Dutch "opschortend koppelteken" (suspended hyphen) construction you might be thinking of—like "voor- en nadelen" (pros and cons)—only works when the shared element comes at the end of the compound words. In that example, both words share "-delen": voordelen and nadelen → voor- en nadelen.
In "XML-data of -foutmelding", you would be trying to share "XML-" at the beginning, which doesn't follow this grammatical pattern. The suspended hyphen doesn't work for shared prefixes in this way.
For the error message, these options would be grammatically correct:
- "Ongeldige XML-data of foutmelding ontvangen" (simplest, matching line 45)
- "Ongeldige XML-data of XML-foutmelding ontvangen" (write it out fully)
- "Ongeldige XML-data of een XML-foutmelding ontvangen" (add "een" for clarity)
I'd recommend the first option for consistency with the existing config.error.response_error message.
🧠 Learnings used
Learnt from: CoMPaTech
Repo: plugwise/plugwise-beta PR: 0
File: :0-0
Timestamp: 2025-01-25T20:42:24.862Z
Learning: The linting rules in plugwise-beta have been updated to use TC001/TC002/TC003 instead of TCH001/TCH002/TCH003 for type-checking related rules.
|
For arguments sake "Ongeldige XML data, of foutmelding ontvangen van de ..." or "XML-data" can be a discussion but there is no such thing as "XML-foutmelding" the second part of that sentence Is correct. Either the XML data is 'corrupt' or there is an error with the communication. |
|
@MathijsG Thanks for your contribution! Your proposal looks good :) But, while we are at this, I'm not completely happy with these translations: What do you think? |
|
Also we should probably just downstream the core strings: https://github.com/home-assistant/core/blob/dev/homeassistant/components/plugwise/strings.json |
|
@CoMPaTech (@MathijsG) then I propose to implement the first suggestion: "Ongeldige XML-data of foutmelding ontvangen". Also @CoMPaTech, your last proposal might cause breakage, changing sensor names? |
|
@bouwew for reference https://gist.github.com/CoMPaTech/6a18e3b8ccac8777f8e762be10cc3137
So I would suggest we inherit as much as possible from Lokalise and just focus on the -beta specific parts. |
Then it should be "Ongeldige XML-data of foutmelding ontvangen" (we don't have spaces in words in the Netherlands) I didn't have the full context on all of the translations, it was just that I spotted 'Electriciteit' on my Plugwise, which bugged me and decided to contribute :). |
|
Yeah @MathijsG no worries, just trying to limit the amount of differences between a testing/beta component and upstream. Also without joining the translation team it's not that easy to get the official translations :) And the quote I gave is from the official HA one - while native I won't claim to be an expert on the NL language - I also frown upon the comma (and other way around the correct way of 'geupdatetetetetetet' instead of 'geupdate' or 'updated' 😦 Reason for mentioning lokalise is that a presumably smaller amount of users follows beta outside of the core one and I would suggest fixing upstream (HA/Lokalise) and updating downstream (beta) would be a more correct way (and also limits doing work twice). But your input is valued, just trying to create process and path of least resistance here. |
|
No problem, I will check whether I can easily join the localisation project of HA. Didn't know part of this was in core already. Geüpdatet is always a struggle, that's why I tend to reside with Bijgewerkt :). |
|
@MathijsG This is the link for Plugwise in Lokalise: https://app.lokalise.com/project/130246255a974bd3b5e8a1.51616605/?view=multi&search=Plugwise You can login via your github account. The term Domestic Hot Water, DHW, is translated as Sanitair Warm Water, SWW. |
3 participants
Updated various Dutch translations for consistency and accuracy.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.