Skip to content

Conversation

@Kaabi
Copy link

@Kaabi Kaabi commented Oct 15, 2025

PHP 8.x throws a deprecation notice when trim() is called with null.
This change casts the argument to string to ensure compatibility and avoid warnings:

Before:
trim($value)

After:
trim((string) $value)

Fix: cast trim() argument to string to prevent null deprecation in PHP 8.x
@pocketarc
Copy link
Owner

This looks promising, but has a lot more changes than are needed (e.g. formatting changes). Would you be able to clean up the diff for this change so that it only includes the minimum set of changes that need to be made to resolve this issue?

Updated array initialization and type handling in DB_query_builder.
@Kaabi
Copy link
Author

Kaabi commented Nov 18, 2025

Done. I’ve cleaned up the diff and reduced it to only the necessary changes needed to resolve the issue. Let me know if anything else should be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants