Skip to content

Rename positron.error_entrace to ark.error_entrace #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lionel- wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

Rename positron.error_entrace to ark.error_entrace #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/ark/src/modules/positron/errors.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
return(handle_error_base(cnd))
}

if (!inherits(cnd, "rlang_error") && !positron_option_error_entrace()) {
if (!inherits(cnd, "rlang_error") && !option_ark_error_entrace()) {
# We have a non-rlang error, but the user requested we dont entrace it
return(handle_error_base(cnd))
}
Expand Down Expand Up @@ -192,9 +192,9 @@ handle_error_rlang <- function(cnd) {
.ps.Call("ps_record_error", evalue, traceback)
}

positron_option_error_entrace <- function() {
# TODO: Wire this up to a Positron option for easy toggling?
isTRUE(getOption("positron.error_entrace", default = TRUE))
option_ark_error_entrace <- function() {
# TODO: Wire this up to a Positron setting for easy toggling?
isTRUE(getOption("ark.error_entrace", default = TRUE))
}

rust_backtrace <- function() {
Expand Down
2 changes: 1 addition & 1 deletion crates/ark/tests/kernel-execute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ fn test_execute_request_incomplete() {

let frontend = DummyArkFrontend::lock();

frontend.execute_request_invisibly("options(positron.error_entrace = FALSE)");
frontend.execute_request_invisibly("options(ark.error_entrace = FALSE)");

frontend.execute_request_error("1 +", |error_msg| {
assert_eq!(error_msg, "Error:\nCan't parse incomplete input");
Expand Down
2 changes: 1 addition & 1 deletion doc/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ A boolean, with a default value of `FALSE`.

If `TRUE`, the special `.Last.value` will be shown in Positron's Variables pane.

## `positron.error_entrace`
## `ark.error_entrace`

A boolean, with a default value of `TRUE`.

Expand Down
Loading