Closed
Conversation
Collaborator
Author
|
Closing in favour of #195. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change commits the cargo lock file. Without it, cargo resolves the latest versions of packages (with matching major version) at CI time. If such updates happen, and new packages are released with breaking changes before we are ready, this can break CI.
This happened today with duckdb v1.10500.0 and arrow v57. Using a lock file should keep CI builds on dependency versions that we know are building on our own machines, until we explicitly update and commit fixes for any breakages.
I think this should also improve the cargo cache hit rate, since package versions will be fixed.