feat: configure Python when reticulate is an R dependency#3552
Closed
zackverham wants to merge 4 commits intomainfrom
Closed
feat: configure Python when reticulate is an R dependency#3552zackverham wants to merge 4 commits intomainfrom
zackverham wants to merge 4 commits intomainfrom
Conversation
During initialization, if an R project has reticulate as a dependency in renv.lock, automatically inject a Python section into the configuration file. This mirrors the existing rpy2 detection for Python projects that require R. Changes: - Add IsRContent() method to ContentType - Add HasReticulateDependency() to check renv.lock for reticulate - Update RequiresPython() to detect reticulate in R projects - Add comprehensive tests for new functionality Closes #1456 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add tests that were missing from the reticulate detection implementation: - TestHasReticulateDependency_WithoutReticulate: tests lockfile without reticulate - TestRequiresPython_ReticulateCheckError: tests error propagation from checker Also fix copyright comment placement in types_test.go. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
Closing this pr because it was relying on the old go implementation, we should rethink the approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During initialization, if an R project has reticulate as a dependency in renv.lock, automatically inject a Python section into the configuration file. This mirrors the existing rpy2 detection for Python projects that require R.
Changes:
Closes #1456
Intent
Type of Change
Approach
User Impact
Automated Tests
Directions for Reviewers
Checklist