Add blank option to server IP-pool select; prompt for rule form#3561
Open
vaibhavheda wants to merge 1 commit into
Open
Add blank option to server IP-pool select; prompt for rule form#3561vaibhavheda wants to merge 1 commit into
vaibhavheda wants to merge 1 commit into
Conversation
Author
|
@willpower232 - Can take this forward please Thanks |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The IP-pool
collection_selecton the server form (and rule form) had no blank option, so once a pool was assigned, there was no UI path to clear it. The model already accepts a nilip_pool_id— only the viewstood in the way.
include_blank: "No specific pool (use rules / default)"(server pool is optional).prompt: "Select an IP pool"(rule pool is required, so prompt is more appropriate than blank).Test plan
servers.ip_pool_id = NULL.QueuedMessagerows haveip_address_id = NULL.