-
Notifications
You must be signed in to change notification settings - Fork 7
Updating user agent formatting #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+35
−1
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4f3f8f0
Updating user agent formatting.
Chriztiaan a3ea2af
Added watchOS tracking.
Chriztiaan 4bf4b93
Merge branch 'main' into chore/user-agent-formatting
Chriztiaan 4f83c11
Added `CurrentVersion.swift` that tracks a libraryVersion variable.
Chriztiaan aa0670d
Sourcing os version for watchOS/tvOs from UIDevice. Dropping operatin…
Chriztiaan 725b101
Moved watchOS to AppKit.
Chriztiaan dc7ca6d
Merge branch 'main' into chore/user-agent-formatting
Chriztiaan b36c40b
Added changelog entry.
Chriztiaan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import Foundation | ||
|
|
||
| #if os(iOS) | ||
| import UIKit | ||
| #elseif os(macOS) | ||
| import AppKit | ||
| #endif | ||
|
|
||
| func userAgent() -> String { | ||
| let libraryVersion = "1.0.0" // TODO: Replace with actual library version | ||
|
|
||
| #if os(iOS) | ||
| let osName = "iOS" | ||
| let osVersion = UIDevice.current.systemVersion | ||
| #elseif os(macOS) | ||
| let osName = "macOS" | ||
| let version = ProcessInfo.processInfo.operatingSystemVersion | ||
| let osVersion = "\(version.majorVersion).\(version.minorVersion)" | ||
| #else | ||
simolus3 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| let osName = "unknown" | ||
| let osVersion = ProcessInfo.processInfo.operatingSystemVersionString | ||
| #endif | ||
|
|
||
| return "powersync-swift/\(libraryVersion) \(osName)/\(osVersion)" | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.