Skip to content

fix: Ensure prerender script isn't merged into entry #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rschristian wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: Ensure prerender script isn't merged into entry #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4afa250
fix: Ensure prerender script isn't merged into entry
rschristian May 11, 2026
705ef15
fix: Other merging
rschristian May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/plugins/prerender-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ function serializeElement(element) {
* @returns {import('vite').Plugin}
*/
export function prerenderPlugin({ prerenderScript, renderTarget, additionalPrerenderRoutes } = {}) {
const originalPrerenderScript = prerenderScript;
let viteConfig = {};
let userEnabledSourceMaps;
let ssrBuild = false;
Expand Down Expand Up @@ -185,7 +186,12 @@ export function prerenderPlugin({ prerenderScript, renderTarget, additionalPrere

config.build.rollupOptions.output ??= {};
config.build.rollupOptions.output.manualChunks = (id) => {
if (id.includes(prerenderScript) || id.includes(preloadPolyfillId)) {
// If the user has specified a prerender script via the plugin options, we don't
// want to merge it into the index, but if they're using `<script prerender>` in their
// HTML, then we do.
//
// As such, we grab & store the original value & check against it here.
if ((!originalPrerenderScript && id.includes(prerenderScript)) || id.includes(preloadPolyfillId)) {
return 'index';
}
};
Expand Down
8 changes: 8 additions & 0 deletions tests/config.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { test } from 'uvu';
import * as assert from 'uvu/assert';
import path from 'node:path';
import { promises as fs } from 'node:fs';

import { setupTest, teardownTest, loadFixture, viteBuild } from './lib/lifecycle.js';
import { getOutputFile, outputFileExists, writeFixtureFile } from './lib/utils.js';
Expand Down Expand Up @@ -30,6 +32,12 @@ test('Should support the `prerenderScript` plugin option', async () => {

const prerenderedHtml = await getOutputFile(env.tmp.path, 'index.html');
assert.match(prerenderedHtml, '<body><h1>Hello, World!</h1>');

const outDirAssets = await fs.readdir(path.join(env.tmp.path, 'dist', 'assets'));

assert.equal(outDirAssets.length, 2);
assert.ok(outDirAssets.some(asset => /^index-/.test(asset)))
assert.ok(outDirAssets.some(asset => /^prerender-/.test(asset)))
});

test('Should throw if no `prerenderScript` is specified or can be found', async () => {
Expand Down
Loading