Upgrade pnpm supply-chain safeguards#41
Closed
JoviDeCroock wants to merge 1 commit into
Closed
Conversation
rschristian
reviewed
May 12, 2026
| }, | ||
| "prettier": "prettier-config-rschristian" | ||
| "prettier": "prettier-config-rschristian", | ||
| "packageManager": "pnpm@11.0.0" |
Member
There was a problem hiding this comment.
I don't see a need for this & would be a strong -1 for it on any of the repos I currently maintain. Keeping to the default ecosystem package manager if much more preferable.
None of our repos are adding/bumping deps often enough for this to really be an issue, nor is it an issue for the org if personal dev machines are compromised (obviously not ideal, but "user beware" when installing any software). Happy to talk about moving this back out of the org before/after preactjs/preset-vite#184 if needed
JoviDeCroock
force-pushed
the
chore/pnpm-11-supply-chain-window
branch
from
b3f1c24 to
1dfa4d8
Compare
JoviDeCroock
force-pushed
the
chore/pnpm-11-supply-chain-window
branch
from
1dfa4d8 to
1b57e7a
Compare
Member
Author
|
Gotcha, yes up to you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minimumReleaseAgewindow for installsWhy
Upgraded every repo to pnpm 11, so we inherit the ecosystem install-cooldown behaviour. It's not a fix on its own. It buys us a window.
Testing