Core: add minTargetedBidCacheTTL so winning bids don't expire (#12987) by vasujain00 · Pull Request #14536 · prebid/Prebid.js

vasujain00 · 2026-02-28T13:12:55Z

Summary

Adds minWinningBidCacheTTL config option to prevent winning bids (that have had targeting set) from expiring, fixing "cannot find ad" / expired render errors when using GPT lazy load with scroll-based render.

Problem

Setting minBidCacheTTL causes "cannot find ad" errors in lazy-load scenarios. The ad is fetched from GPT, but the scroll milestone for render takes a long time. Winning bids expire and are dropped from memory before GPT can render them.

Solution

minWinningBidCacheTTL – When set, overrides minBidCacheTTL for bids that have had targeting set (winning bids sent to the ad server).
If unset, behavior is unchanged (all bids use minBidCacheTTL).
Set to Infinity (or a large value) to effectively never expire winning bids.

Usage

pbjs.setConfig({
  minBidCacheTTL: 30,
  minWinningBidCacheTTL: Infinity  // keep winning bids indefinitely for lazy-load GPT
});

Changes

src/bidTTL.ts – Added minWinningBidCacheTTL config, getMinWinningBidCacheTTL(), and getEffectiveMinBidCacheTTL(bid)
src/auction.ts – Use effective TTL per bid; refresh bid TTL when targeting is set
src/auctionManager.js – Use effective TTL when calculating auction TTL

Testing

gulp lint – passed
gulp test --file test/spec/auctionmanager_spec.js – 91 tests passed

Labels

feature | minor

Fixes #12987

- Updated auction and auctionManager to utilize getEffectiveMinBidCacheTTL for determining bid TTL based on targeting status. - Added minWinningBidCacheTTL configuration to allow for differentiated TTL handling for winning bids. - Enhanced bidTTL module with new functions to support effective TTL calculations. - Updated tests to cover new TTL logic and configurations, ensuring correct behavior for bids with and without targeting set.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c06c4650ea

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-28T13:16:33Z

+    ttl: (au) => au.end.then(() => {
+      const bids = au.getBidsReceived();
+      if (bids.length === 0) {
+        const minTTL = getMinBidCacheTTL();
+        return minTTL == null ? null : minTTL * 1000;


Refresh auction TTL when targeting status is updated

The auction-level TTL is computed once inside au.end.then(...), so it snapshots each bid’s status at auction end; however bids are marked BID_TARGETING_SET later via setStatusForBids when setTargetingForGPT runs. Because _auctions.refresh() is never triggered on that status transition, auctions can still expire using the pre-targeting TTL (for example minBidCacheTTL/bid TTL) instead of minWinningBidCacheTTL, which reintroduces the lazy-load renderAd/"cannot find ad" failure this change is trying to prevent when all bids have short TTLs.

Useful? React with 👍 / 👎.

patmmccann · 2026-03-02T15:32:52Z

@vasujain00 thanks for the feature! could you link a docs pull?

coveralls · 2026-03-02T19:14:25Z

Pull Request Test Coverage Report for Build 23916937393

Details

63 of 63 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 96.338%

Totals
Change from base Build 23913364353:	0.003%
Covered Lines:	216694
Relevant Lines:	224930

💛 - Coveralls

monis0395 · 2026-03-04T10:17:02Z

Hi, I am a little caught up in some tasks will review this tom.

dgirardi

Even addressing the refresh issue, I have some concerns with this:

the current logic picks the maximum between minBidCacheTTL and the bid's own .ttl. If we need this feature it should mean that either the bid's .ttl is inaccurate, or that rendering will not yield revenue. Calling out vendors that need to fix their TTL and working around the problem by overriding it using the bidResponse event might be a better way to address this. There's also an open issue #13838 on how to make refreshing easier.
a bid that was sent to the ad server (targeting set) is not a winning bid; unfortunately we can't really know which bids should be "saved" as we know what won only by the time we need to render it. In the general case, any bid may win at any point in the future, since even those that were not selected for targeting may still be picked from cache later. And likewise bids that were used for targeting may never win. So I don't think there's a clean way to do this besides fixing bids' TTLs.

I can see how this can still be useful but I think the setting should be called something else, maybe minTargetedBidCacheTTL.

olafbuitelaar · 2026-03-09T12:30:07Z

any concerns about SSP's validating server side if the bid has been expired and hence wouldn't attribute revenue (if the bid was rendered after the TTL), because the bid was expired on their end?

patmmccann · 2026-03-09T15:45:12Z

we're having some debate on if winning is the correct terminology here

perhaps minSentBidCacheTTL or minPassedBidCacheTTL or targeted?

patmmccann · 2026-03-09T15:48:21Z

any concerns about SSP's validating server side if the bid has been expired and hence wouldn't attribute revenue (if the bid was rendered after the TTL), because the bid was expired on their end?

yes we certainly wouldnt want to make this default behavior. I think docs pr here should explain to the publisher the choice they need to make when expiring bids. When bids expire after targeting but before rendering, should they hold a new auction, do nothing, or just render? When bids are missing from the cache bc they are doing memory saving techniques, they should also be making an explicit choice.

vasujain00 · 2026-03-12T07:50:38Z

@patmmccann Docs: add minWinningBidCacheTTL / targeted-bid cache TTL to setConfig
#6479

github-actions · 2026-03-18T04:20:05Z

Tread carefully! This PR adds 6 linter errors (possibly disabled through directives):

src/auctionManager.js (+6 errors)

monis0395 · 2026-03-19T10:38:45Z

@vasujain00 There are some unresolved comments please resolve those

vasujain00 · 2026-03-21T06:46:25Z

Just to confirm the only change needed is replacing minWinningBidCacheTTL with minTargetedBidCacheTTL, correct?

@monis0395 please confirm if that’s the only issue.

github-actions · 2026-03-22T01:22:18Z

Tread carefully! This PR adds 6 linter errors (possibly disabled through directives):

src/auctionManager.js (+6 errors)

dgirardi · 2026-03-23T15:34:10Z

+          await auction.end;
+          const shortTtlBid = auctionManager.getBidsReceived().find(b => b.ttl === 10);
+          auctionManager.setStatusForBids(shortTtlBid.adId, BID_STATUS.BID_TARGETING_SET);
+          await clock.tick(35 * 1000);


I think the bot is still correct: an auction can be dropped from auctionManager even if the bids within it are refreshed. You can see it in this test case if you replace this clock.tick with

await clock.tick(105 * 1000); await clock.tick(0);

105 is to allow every bid's "original" ttl to expire; at that point the "winning" bid is retained in the auction, but the auction itself is no longer used for auctionManager.getBidsReceived(), because the auction set did not do a TTL refresh.

The second await is necessary to get the cleanup logic to run.

monis0395 · 2026-03-25T06:00:41Z

Calling out vendors that need to fix their TTL and working around the problem by overriding it using the bidResponse event might be a better way to address this.

This is a valid point.

There also another edge case. If bidCaching: true, sendAllBids: true, it could repeatedly reuse bids since the TTL may effectively become infinite, for example when minWinningBidCacheTTL: Infinity or a very high value. This could also occur with bidCaching: true, sendAllBids: false, though the impact would be smaller.

There may not be a clear solution beyond reporting it. This likely needs further discussion in the PMC.

What are your thoughts? @vasujain00 @patmmccann @dgirardi

monis0395 · 2026-03-26T10:46:08Z

Calling out vendors that need to fix their TTL and working around the problem by overriding it using the bidResponse event might be a better way to address this.

This is a valid point.

There also another edge case. If bidCaching: true, sendAllBids: true, it could repeatedly reuse bids since the TTL may effectively become infinite, for example when minWinningBidCacheTTL: Infinity or a very high value. This could also occur with bidCaching: true, sendAllBids: false, though the impact would be smaller.

There may not be a clear solution beyond reporting it. This likely needs further discussion in the PMC.

What are your thoughts? @vasujain00 @patmmccann @dgirardi

Had a discussion with digirardi, bidCaching would remain unaffected.

So only 2 changes are required @vasujain00

Config name change
fixing the refresh issue which dgirardi mentioned

- Refactored bid TTL logic to replace minWinningBidCacheTTL with minTargetedBidCacheTTL for better clarity and functionality. - Updated related functions and configurations to reflect the new naming and ensure correct behavior for bids with targeting set. - Enhanced tests to validate the new TTL handling for targeted bids, ensuring accurate cache expiration logic.

Made-with: Cursor

vasujain00 · 2026-03-27T20:48:54Z

Pushed the review fixes: minTargetedBidCacheTTL, plus refreshing the auction manager when targeting is set (not only the inner bid list), and test tweaks. On bidCaching this is memory retention for targeted bids, not a redesign of bid caching. Happy to adjust if you see something I missed.

github-actions · 2026-03-30T16:42:06Z

Tread carefully! This PR adds 6 linter errors (possibly disabled through directives):

src/auctionManager.js (+6 errors)

chatgpt-codex-connector bot reviewed Feb 28, 2026

View reviewed changes

patmmccann requested review from dgirardi and monis0395 March 2, 2026 15:31

patmmccann added the feature label Mar 2, 2026

monis0395 approved these changes Mar 5, 2026

View reviewed changes

dgirardi reviewed Mar 5, 2026

View reviewed changes

Comment thread test/spec/auctionmanager_spec.js

Merge branch 'master' into feature/min-winning-bid-cache-ttl-codex

94715e4

vasujain00 mentioned this pull request Mar 12, 2026

Docs: add minWinningBidCacheTTL / targeted-bid cache TTL to setConfig prebid/prebid.github.io#6479

Merged

1 task

vasujain00 and others added 3 commits March 13, 2026 08:07

Merge branch 'master' into feature/min-winning-bid-cache-ttl-codex

f6852cb

Merge branch 'master' into feature/min-winning-bid-cache-ttl-codex

9d8c9ea

Merge branch 'master' into feature/min-winning-bid-cache-ttl-codex

cb7c2c3

dgirardi reviewed Mar 23, 2026

View reviewed changes

vasujain00 added 3 commits March 27, 2026 17:08

accepted incoming changes

b270d7f

chore: remove unnecessary documentation drafts

87a026d

Made-with: Cursor

dgirardi approved these changes Mar 30, 2026

View reviewed changes

patmmccann and others added 4 commits March 30, 2026 13:21

Merge branch 'master' into feature/min-winning-bid-cache-ttl-codex

57a896d

Reformat import statements in auction.ts

ebad372

Update auctionManager.js

5ab49fb

Import AdUnitDefinition type in auction.ts

675a9e1

patmmccann changed the title ~~Core: add minWinningBidCacheTTL so winning bids don't expire (#12987)~~ Core: add minTargetedBidCacheTTL so winning bids don't expire (#12987) Apr 2, 2026

patmmccann and others added 5 commits April 2, 2026 10:58

Update bidTTL.ts

ba8db67

Fix import formatting in auctionmanager_spec.js

fe10d33

Update auctionmanager_spec.js

c526869

Update auctionmanager_spec.js

3169267

Merge branch 'master' into feature/min-winning-bid-cache-ttl-codex

74fd37d

patmmccann merged commit ce33004 into prebid:master Apr 2, 2026
102 checks passed

Conversation

vasujain00 commented Feb 28, 2026

Summary

Problem

Solution

Usage

Changes

Testing

Labels

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

patmmccann commented Mar 2, 2026

Uh oh!

coveralls commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 23916937393

Details

💛 - Coveralls

Uh oh!

monis0395 commented Mar 4, 2026

Uh oh!

dgirardi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

olafbuitelaar commented Mar 9, 2026

Uh oh!

patmmccann commented Mar 9, 2026

Uh oh!

patmmccann commented Mar 9, 2026

Uh oh!

vasujain00 commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 18, 2026

Uh oh!

monis0395 commented Mar 19, 2026

Uh oh!

vasujain00 commented Mar 21, 2026

Uh oh!

github-actions bot commented Mar 22, 2026

Uh oh!

dgirardi Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

monis0395 commented Mar 25, 2026

Uh oh!

monis0395 commented Mar 26, 2026

Uh oh!

vasujain00 commented Mar 27, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

coveralls commented Mar 2, 2026 •

edited

Loading

vasujain00 commented Mar 12, 2026 •

edited

Loading