Skip to content

Adplus id v2 updates#14576

Merged
patmmccann merged 11 commits intoprebid:masterfrom
tccdeniz:adplusId_v2_updates
Apr 13, 2026
Merged

Adplus id v2 updates#14576
patmmccann merged 11 commits intoprebid:masterfrom
tccdeniz:adplusId_v2_updates

Conversation

@tccdeniz
Copy link
Copy Markdown
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

We updated our user id module and added two additional parameters to bidder adapter to send our SSP. These changes doesn't affect the user-facing APIs. I didn't separated PRs for the user id module and bidder adapter because these changes needs to included in the same release as well as the changes in bidder adapter side are minor.

Thanks.

Other information

@review-assignment-bot review-assignment-bot bot requested a review from gwhigs March 11, 2026 05:06
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 970f8431e8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread modules/adplusIdSystem.js
Comment thread modules/adplusIdSystem.js Outdated
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Mar 11, 2026

Coverage Report for CI Build 24185737855

Coverage decreased (-0.005%) to 96.337%

Details

  • Coverage decreased (-0.005%) from the base build.
  • Patch coverage: 22 uncovered changes across 2 files (71 of 93 lines covered, 76.34%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
modules/adplusIdSystem.js 57 40 70.18%
modules/adplusBidAdapter.js 8 3 37.5%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 224979
Covered Lines: 216738
Line Coverage: 96.34%
Relevant Branches: 52487
Covered Branches: 42624
Branch Coverage: 81.21%
Branches in Coverage %: No
Coverage Strength: 71.06 hits per line

💛 - Coveralls

@tccdeniz
Copy link
Copy Markdown
Contributor Author

tccdeniz commented Apr 9, 2026

Hi @gwhigs. Is it possible to speed up the review process a bit for this PR?

@patmmccann patmmccann merged commit f0501e5 into prebid:master Apr 13, 2026
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants