Skip to content

Revealon Bid Adapter: initial release#14618

Merged
patmmccann merged 3 commits intoprebid:masterfrom
Chucky-choo:master
Apr 13, 2026
Merged

Revealon Bid Adapter: initial release#14618
patmmccann merged 3 commits intoprebid:masterfrom
Chucky-choo:master

Conversation

@Chucky-choo
Copy link
Copy Markdown
Contributor

Type of change

  • New bidder adapter

Description of change

[
    {
        code: 'test-banner',
        mediaTypes: {
            banner: {
                sizes: [[300, 250]],
            }
        },
        bids: [
            {
                bidder: 'revealon',
                params: {
                    env: 'revealon',
                    pid: 'aa8217e20131c095fe9dba67981040b0',
                    ext: {}
                }
            }
        ]
    },
    {
        code: 'test-video',
        sizes: [ [ 640, 480 ] ],
        mediaTypes: {
            video: {
                playerSize: [640, 480],
                context: 'instream',
                skipppable: true
            }
        },
        bids: [{
            bidder: 'revealon',
            params: {
                env: 'revealon',
                pid: 'aa8217e20131c095fe9dba67981040b0',
                ext: {}
            }
        }]
    }
]

Other information

Docs RP: prebid/prebid.github.io#6493

@github-actions
Copy link
Copy Markdown

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

  • modules/revealonBidAdapter.js

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Mar 19, 2026

Pull Request Test Coverage Report for Build 23438876026

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 178 of 178 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 96.346%

Totals Coverage Status
Change from base Build 23344366270: 0.003%
Covered Lines: 216364
Relevant Lines: 224569

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

  • modules/revealonBidAdapter.js

Comment thread modules/revealonBidAdapter.js Outdated
getUserSyncs
}

registerBidder(spec);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex what would this adapter need to do to change this file typescript?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question. For this PR comment, the reviewer is basically asking for a JS → TS migration of modules/revealonBidAdapter.js, with explicit typing for the adapter’s public interface (especially bid params/config).

What the adapter would need to do

At a minimum, it should follow the same TypeScript pattern used by existing TS adapters in this repo:

  1. Rename the file to .ts

    • modules/revealonBidAdapter.jsmodules/revealonBidAdapter.ts (and keep same module registration behavior).
    • Existing TS adapters end with registerBidder(spec).
  2. Type the Prebid adapter contract

    • Use typed imports like BidderSpec, AdapterRequest, BidRequest, ClientBidderRequest, ORTBRequest where relevant.
    • Define the spec as BidderSpec<typeof BIDDER_CODE>.
  3. Define and enforce bidder params type

    • Add a concrete RevealonBidParams type for params used by this bidder, including required/optional semantics (many adapters use a helper like RequireAtLeastOne).
    • Wire params into Prebid’s global bidder param typing via module augmentation:
      declare module '../src/adUnits' {
        interface BidderParams {
          [BIDDER_CODE]: RevealonBidParams;
        }
      }
      (pattern used across TS adapters).
  4. Type key methods

    • isBidRequestValid(bid: BidRequest<typeof BIDDER_CODE>): boolean
    • buildRequests(...): AdapterRequest
    • Type ORTB/intermediate request objects where applicable.
  5. Keep logic, add type safety

    • The migration is expected to preserve behavior while adding strongly typed public touchpoints (params, request config, response handling hooks).
    • Reviewer’s note explicitly calls out “well-defined types” for public API interactions, so params/config typing is the must-have.

Practical checklist for the author

  • Convert file extension to .ts
  • Add RevealonBidParams type
  • Add declare module '../src/adUnits' mapping for revealon
  • Add BidRequest<typeof BIDDER_CODE> / ClientBidderRequest<typeof BIDDER_CODE> / AdapterRequest annotations
  • Ensure spec is typed BidderSpec<typeof BIDDER_CODE>
  • Run lint + targeted adapter test per repo guidelines

Commands I used to validate patterns

  • rg --files -g 'AGENTS.md'
  • rg --files modules | rg 'BidAdapter\\.ts$|\\.ts$' | head -n 20
  • sed -n '1,240p' modules/revnewBidAdapter.ts
  • sed -n '1,220p' modules/adgridBidAdapter.ts
  • nl -ba modules/revnewBidAdapter.ts | sed -n '1,220p'
  • nl -ba modules/adgridBidAdapter.ts | sed -n '1,220p'

I did not make code changes in this workspace, so no commit/PR was created.

View task →

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've addressed all the review feedback. Could someone please take another look? Thanks!

@Chucky-choo Chucky-choo requested a review from patmmccann March 27, 2026 10:47
@patmmccann patmmccann merged commit ad24dc6 into prebid:master Apr 13, 2026
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants