Support concat array merge for bidder config#4729
Open
postindustria-code wants to merge 2 commits intoprebid:masterfrom
Open
Support concat array merge for bidder config#4729postindustria-code wants to merge 2 commits intoprebid:masterfrom
postindustria-code wants to merge 2 commits intoprebid:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #4111
Implements a new
concatarray merge mode forext.prebid.bidderconfig.Configurable via
account_defaults.bidderconfig.array_merge. When set toconcat, instead of overwriting base arrays with bidder-specific config, the bidder-specific entries are appended to the end of the base arrays.Note on
dooh.content.data:Although
doohwas mentioned in the original discussion, it is not supported in this implementation. Theopenrtb_ext.ORTB2struct does not have a DOOH field, and theResolveFPD()flow does not handle it. It only operates with user, app, site and device. The dooh support may be a typo in the original spec or a divergence from pbs-java. If dooh support has business value, it should be tracked and implemented as a separate task.