-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update reference docs with the changes made in V10 #6506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
5cd3368
451990f
7d6f2f2
4680598
6ba9d95
f327ec8
11d3777
76be8f0
de13528
a2231eb
65da7f2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,19 @@ | ||
| --- | ||
| layout: api_prebidjs | ||
| title: pbjs.adServers.dfp.buildAdpodVideoUrl(options) <span style="color:red" markdown="1">[Alpha]</span> | ||
| description: adServers.dfp.buildAdpodVideoUrl API | ||
| title: pbjs.adServers.gam.buildAdpodVideoUrl(options) <span style="color:red" markdown="1">[Alpha]</span> | ||
| description: adServers.gam.buildAdpodVideoUrl API | ||
| sidebarType: 1 | ||
| --- | ||
|
|
||
|
|
||
| {: .alert.alert-info :} | ||
| The GAM implementation of this function requires including the `dfpAdServerVideo` module in your Prebid.js build. | ||
| The GAM implementation of this function requires including the `gamAdServerVideo` module in your Prebid.js build. | ||
|
|
||
| This method combines publisher-provided parameters with Prebid.js targeting parameters to build a GAM video ad tag URL that can be used by a video player. | ||
|
|
||
| #### Argument Reference | ||
| ## Argument Reference | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't like this, but I had to do it in a few places to satisfy the linter. Note that there are a bunch more files that would violate this rule |
||
|
|
||
| ##### The `options` object | ||
| ### The `options` object | ||
|
|
||
| {: .table .table-bordered .table-striped } | ||
| | Field | Type | Description | | ||
|
|
@@ -23,7 +23,7 @@ This method combines publisher-provided parameters with Prebid.js targeting para | |
|
|
||
| {% include alerts/alert_important.html content="For long form Prebid.js will add key-value strings for multiple bids. This prevents retrieving the description url from bid." %} | ||
|
|
||
| #### Example | ||
| ## Example | ||
|
|
||
| ```JavaScript | ||
| pbjs.que.push(function(){ | ||
|
|
@@ -42,7 +42,7 @@ pbjs.que.push(function(){ | |
|
|
||
| pbjs.requestBids({ | ||
| bidsBackHandler: function(bids) { | ||
| pbjs.adServers.dfp. buildAdpodVideoUrl({ | ||
| pbjs.adServers.gam. buildAdpodVideoUrl({ | ||
| codes: ['sample-code'], | ||
| params: { | ||
| iu: '/123456/testing/prebid.org/adunit1', | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ This function returns the bid responses at the given moment. | |
|
|
||
| **Kind**: static method of `pbjs`. | ||
|
|
||
| **Returns**: `object` - map | object that contains the bidResponses. | ||
| **Returns**: `object` - map | object that contains for each ad unit the array of bid responses. For backwards compatibility, the arrays expose the array also under the `.bids` property. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if we want to keep the "For backwards compatibility, ..." sentence in here. I added it because otherwise people might inspect what they get from this method, and discover that it is not in sync with the docs / wonder why there is an additional |
||
|
|
||
| **Returned Object Params**: | ||
|
|
||
|
|
@@ -36,7 +36,6 @@ This function returns the bid responses at the given moment. | |
| | `adserverTargeting` | Object | Contains all the adserver targeting parameters | `{ "hb_bidder": "appnexus", "hb_adid": "7a53a9d3" }` | | ||
| | `native` | Object | Contains native key value pairs. | `{ "title": "", "body": "" }` | | ||
| | `status` | String | Status of the bid. Possible values: targetingSet, rendered | `"targetingSet"` | | ||
| | `statusMessage` | String | The bid's status message | "Bid returned empty or error response" or "Bid available" | | ||
| | `ttl` | Integer | How long (in seconds) this bid is considered valid. See this [FAQ entry]({{site.github.url}}/dev-docs/faq.html#does-prebidjs-cache-bids) for more info. | `300` | | ||
|
|
||
| <div class="panel-group" id="accordion" role="tablist" aria-multiselectable="true"> | ||
|
|
@@ -54,13 +53,11 @@ This function returns the bid responses at the given moment. | |
|
|
||
| ```json | ||
| { | ||
| "/9968336/header-bid-tag-0": { | ||
| "bids": [ | ||
| "/9968336/header-bid-tag-0": [ | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't really saw a way to include the |
||
| { | ||
| "bidderCode": "appnexus", | ||
| "width": 300, | ||
| "height": 250, | ||
| "statusMessage": "Bid available", | ||
| "adId": "7a53a9d3", | ||
| "creative_id": 29681110, | ||
| "cpm": 0.5, | ||
|
|
@@ -81,7 +78,6 @@ This function returns the bid responses at the given moment. | |
| "bidderCode": "pubmatic", | ||
| "width": "300", | ||
| "height": "250", | ||
| "statusMessage": "Bid available", | ||
| "adId": "1139e34e14", | ||
| "adSlot": "39620189@300x250", | ||
| "cpm": 1, | ||
|
|
@@ -105,7 +101,6 @@ This function returns the bid responses at the given moment. | |
| "bidderCode": "rubicon", | ||
| "width": "300", | ||
| "height": "250", | ||
| "statusMessage": "Bid available", | ||
| "adId": "130d3b0d9b", | ||
| "cpm": 0.795995, | ||
| "ad": "<scri...pt>", | ||
|
|
@@ -124,15 +119,12 @@ This function returns the bid responses at the given moment. | |
| "hb_pb": "0.50" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "/9968336/header-bid-tag1": { | ||
| "bids": [ | ||
| ], | ||
| "/9968336/header-bid-tag1": [ | ||
| { | ||
| "bidderCode": "casale", | ||
| "width": 0, | ||
| "height": 0, | ||
| "statusMessage": "Bid returned empty or error response", | ||
| "adId": "108c0ba49d", | ||
| "requestTimestamp": 1444844944130, | ||
| "responseTimestamp": 1444844944223, | ||
|
|
@@ -145,7 +137,6 @@ This function returns the bid responses at the given moment. | |
| "bidderCode": "openx", | ||
| "width": "728", | ||
| "height": "90", | ||
| "statusMessage": "Bid available", | ||
| "adId": "14d7f9208f", | ||
| "ad_id": "537161420", | ||
| "cpm": 1.717, | ||
|
|
@@ -164,7 +155,6 @@ This function returns the bid responses at the given moment. | |
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
|
|
@@ -188,8 +178,7 @@ This function returns the bid responses at the given moment. | |
|
|
||
| ```json | ||
| { | ||
| "div-banner-outstream-native" : { | ||
| "bids" : [ | ||
| "div-banner-outstream-native" : [ | ||
| { | ||
| "pbMg" : "10.00", | ||
| "pbLg" : "5.00", | ||
|
|
@@ -250,12 +239,10 @@ This function returns the bid responses at the given moment. | |
| "ttl" : 300, | ||
| "status" : "targetingSet", | ||
| "height" : 0, | ||
| "statusMessage" : "Bid available", | ||
| "cpm" : 10, | ||
| "currency" : "USD" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the
adServers.dfp.xxxis still present in V10 and higher, an alternative would be to have 2 versions of the file.dfpfile, with a warning at the topFor now, I went for the least amount of work approach and only kept the
.gam.version in the docs