systemtests: archive fieldcompare diff files on failure #742
systemtests: archive fieldcompare diff files on failure #742AdityaGupta716 wants to merge 4 commits intoprecice:developfrom
Conversation
345ddbd to
065c8b2
Compare
|
hi @MakisH, plz review! The |
cdffa12 to
35bceea
Compare
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/gsoc-2026-aditya-gupta/2773/4 |
|
@MakisH This one searches recursively for diff files in subdirectories, matches all output formats fieldcompare produces not just VTK, has the safety check to avoid copy loops, and adds logging for the really common case where fieldcompare fails but doesn't end up writing any diff files at all. |
34df3a7 to
d974d60
Compare
What this PR does
When fieldcompare fails, the diff VTK files it generates (via the
--diffflag already present in the compose template) are now copied to adiff-results/folder inside the system test directory. This means they get included in the CI artifact and can be downloaded for visual inspection of exactly where results diverged.Closes #441
Changes
__archive_diff_files()toSystemtest.py— scansprecice-exports/for any*diff*.vtu,*diff*.vtk, or*diff*.vtpfiles after a fieldcompare failure and copies them todiff-results/fieldcompare_result.exit_code != 0— no unnecessary copies on passing runsREADME.mdto mention that diff files are available indiff-results/for ParaView inspectionNotes
The
--diffflag is already passed to fieldcompare indocker-compose.field_compare.template.yaml, so the diff files are already being generated — they just weren't being saved anywhere accessible until now.Checklist
changelog-entries/742.md