Skip to content

Remove redundant default substeps options #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MakisH wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Remove redundant default substeps options #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ab49be
Remove redundant default substeps options
MakisH May 17, 2026
5f8054d
Add changelog entry
MakisH May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog-entries/786.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Remove redundant `substeps="true"` option (default) from the oscillator, oscillator-overlap, partitioned-heat-condiction, and resonant-circuit tutorials. [#786](https://github.com/precice/tutorials/pull/786)
6 changes: 2 additions & 4 deletions oscillator-overlap/precice-config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,12 @@
mesh="Mass-Left-Mesh"
from="Mass-Left"
to="Mass-Right"
initialize="true"
substeps="true" />
initialize="true" />
<exchange
data="Displacement-Right"
mesh="Mass-Left-Mesh"
from="Mass-Right"
to="Mass-Left"
initialize="true"
substeps="true" />
initialize="true" />
</coupling-scheme:serial-implicit>
</precice-configuration>
6 changes: 2 additions & 4 deletions oscillator/precice-config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,12 @@
mesh="Mass-Left-Mesh"
from="Mass-Left"
to="Mass-Right"
initialize="true"
substeps="true" />
initialize="true" />
<exchange
data="Force-Right"
mesh="Mass-Left-Mesh"
from="Mass-Right"
to="Mass-Left"
initialize="true"
substeps="true" />
initialize="true" />
</coupling-scheme:serial-implicit>
</precice-configuration>
6 changes: 2 additions & 4 deletions partitioned-heat-conduction/precice-config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,13 @@
mesh="Dirichlet-Mesh"
from="Dirichlet"
to="Neumann"
initialize="true"
substeps="true" />
initialize="true" />
<exchange
data="Temperature"
mesh="Neumann-Mesh"
from="Neumann"
to="Dirichlet"
initialize="true"
substeps="true" />
initialize="true" />
<relative-convergence-measure data="Heat-Flux" mesh="Dirichlet-Mesh" limit="1e-10" />
<relative-convergence-measure data="Temperature" mesh="Neumann-Mesh" limit="1e-10" />
<!-- <acceleration:IQN-ILS>
Expand Down
4 changes: 2 additions & 2 deletions resonant-circuit/precice-config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@
<max-time value="10" />
<time-window-size value="1" />
<max-iterations value="100" />
<exchange data="Current" mesh="Coil-Mesh" from="Coil" to="Capacitor" substeps="true" />
<exchange data="Voltage" mesh="Coil-Mesh" from="Capacitor" to="Coil" substeps="true" />
<exchange data="Current" mesh="Coil-Mesh" from="Coil" to="Capacitor" />
<exchange data="Voltage" mesh="Coil-Mesh" from="Capacitor" to="Coil" />
<relative-convergence-measure limit="1e-3" data="Current" mesh="Coil-Mesh" />
<relative-convergence-measure limit="1e-3" data="Voltage" mesh="Coil-Mesh" />
</coupling-scheme:serial-implicit>
Expand Down