This repository was archived by the owner on Feb 25, 2020. It is now read-only.
Open
Conversation
added 9 commits
January 21, 2013 13:23
Change collections to use streamTs
add configuration via mongodb
add org to build.sbt
tools/import/jdbc/build.sbt
Outdated
Contributor
There was a problem hiding this comment.
This should probably be updated to 1.0.0-M7.7 - there are a ton of bugfixes since M6
Contributor
There was a problem hiding this comment.
This suggests the presence of an ImportMongo shell/bat script, which is isn't found on this PR. It might be worthwhile to explain what each parameter looks like as well, as the person doing this might not be familiar with mongo, assuming he uses it through some other tool, and is probably not familiar with precog.
For example, it is not immediately obvious that you want/need your accountId on the path, whereas an example would make that clear.
…nto MongoImport Conflicts: tools/import/jdbc/src/main/scala/com/precog/tools/importers/jdbc/ImportJdbc.scala
tools/import/common/build.sbt
Outdated
Contributor
There was a problem hiding this comment.
I'd leave off the explicit scalaz dependency here and use the transitive dep from blueeyes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.