Proof of concept for being able to test correct loading of config values from file#6
Open
Proof of concept for being able to test correct loading of config values from file#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested by @jkebinger, this provides a local config override file and tests to ensure all its values are loaded.
Changes required in integration test harnesses:
prefab_envsfrom theclient_overridesmap in test datapath/to/integration/data/tests/current/versiontheprefab_config_classpath_dirvalue in the Options you build for running the integration teststests/directoryI think that should be it. I'll build out the proof of concept in the Elixir library to confirm
Important files to note here are
.prefab.integration.config.yamlandtests/get_local_overrides.yaml