Documented and formatted a lot of files to sync with pokeemerald#636
Open
HunarPG wants to merge 38 commits intopret:masterfrom
Open
Documented and formatted a lot of files to sync with pokeemerald#636HunarPG wants to merge 38 commits intopret:masterfrom
HunarPG wants to merge 38 commits intopret:masterfrom
Conversation
…ttle_ai_scripts.s
…, wirelessWinTop, wirelessWinRight and wirelessWinBottom respectively
…nd STRINGID_GOTCHAPKMNCAUGHT2 to STRINGID_GOTCHAPKMNCAUGHTOLDMANORDUDE
Author
|
And pushed more changes |
HunarPG
changed the title
Member
GriffinRichards
left a comment
GriffinRichards
left a comment
There was a problem hiding this comment.
Thanks! Keep in mind when syncing things between pokefirered and pokeemerald that just copying everything over isn't sufficient. There are many names pokefirered uses that are better than the equivalent in pokeemerald, and there are game differences to account for.
…eld_effect_object_tmplate_pointers.h to extern const struct instead of const struct
…tatic bool8 and sMovementActionFuncs to gMovementActionFuncs matching emerald
…h and also changed sItemEffect to gItemEffect
…nst u32 in src/data/pokemon//tmhm_learnsets.h
Comment on lines
-12
to
+15
| #define tWin0Left data[3] | ||
| #define tWin0Right data[4] | ||
| #define tWin0Top data[5] | ||
| #define tWin0Bottom data[6] | ||
| #define tWinLeft data[3] | ||
| #define tWinRight data[4] | ||
| #define tWinTop data[5] | ||
| #define tWinBottom data[6] |
Member
There was a problem hiding this comment.
Any reason for this change?
Author
There was a problem hiding this comment.
Is there any reason to keep 0 in between these names??
Like there is no tWin1Left, tWin2Left or something
And of course it's consistent with pokeemerald
…to BattleScript_ActionLeftoverWallyPrepToThrow
Collaborator
|
grooming: is this still on the review docket? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.