fix(composer): support slashes in dist download version routes#85
Merged
maartenbode merged 1 commit intopricorephp:mainfrom Mar 31, 2026
Merged
Conversation
Member
|
Thanks for the contribution, Jeroen! Clean fix and nice test coverage. All tests pass. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev-feat/ZON-185967-add-db-storage)versionandreferenceroute parametersProblem
Composer dev branch versions like
dev-feat/my-featurecontain forward slashes. When used in the dist download URL, Laravel's router splits the version on/, breaking parameter matching and returninga 404.
Solution
Added
whereconstraints to the dist download route:version:[a-zA-Z0-9_./-]+— allows slashesreference:[a-f0-9]+— restricted to hex (git SHA), so Laravel can distinguish version from referenceTest plan