-
Notifications
You must be signed in to change notification settings - Fork 656
Remove link underline effect on hover for Link and Button variant link #7676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
4
commits into
main
Choose a base branch
from
copilot/remove-link-underline-effect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1ab8ba9
Remove link underline effect on hover for Link and Button variant link
Copilot 6c3c0fc
test(vrt): update snapshots
HiroAgustin b3bda7c
Merge branch 'main' into copilot/remove-link-underline-effect
llastflowers 2bb322c
Merge branch 'main' into copilot/remove-link-underline-effect
HiroAgustin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@primer/react': patch | ||
| --- | ||
|
|
||
| Remove link underline effect on hover for both Link (inline) and Button with variant link (no visuals) |
Binary file modified
BIN
-924 Bytes
(84%)
...s/components/Link.test.ts-snapshots/Link-Inline-dark-colorblind-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-857 Bytes
(84%)
...s/components/Link.test.ts-snapshots/Link-Inline-dark-colorblind-hover-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-958 Bytes
(84%)
...shots/components/Link.test.ts-snapshots/Link-Inline-dark-dimmed-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-863 Bytes
(84%)
...shots/components/Link.test.ts-snapshots/Link-Inline-dark-dimmed-hover-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-924 Bytes
(84%)
...ht/snapshots/components/Link.test.ts-snapshots/Link-Inline-dark-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-929 Bytes
(84%)
...omponents/Link.test.ts-snapshots/Link-Inline-dark-high-contrast-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-853 Bytes
(84%)
...omponents/Link.test.ts-snapshots/Link-Inline-dark-high-contrast-hover-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-857 Bytes
(84%)
...ht/snapshots/components/Link.test.ts-snapshots/Link-Inline-dark-hover-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-924 Bytes
(84%)
...s/components/Link.test.ts-snapshots/Link-Inline-dark-tritanopia-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-857 Bytes
(84%)
...s/components/Link.test.ts-snapshots/Link-Inline-dark-tritanopia-hover-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-884 Bytes
(84%)
.../components/Link.test.ts-snapshots/Link-Inline-light-colorblind-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-832 Bytes
(84%)
.../components/Link.test.ts-snapshots/Link-Inline-light-colorblind-hover-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-884 Bytes
(84%)
...t/snapshots/components/Link.test.ts-snapshots/Link-Inline-light-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-900 Bytes
(84%)
...mponents/Link.test.ts-snapshots/Link-Inline-light-high-contrast-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-852 Bytes
(84%)
...mponents/Link.test.ts-snapshots/Link-Inline-light-high-contrast-hover-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-832 Bytes
(84%)
...t/snapshots/components/Link.test.ts-snapshots/Link-Inline-light-hover-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-884 Bytes
(84%)
.../components/Link.test.ts-snapshots/Link-Inline-light-tritanopia-focus-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-832 Bytes
(84%)
.../components/Link.test.ts-snapshots/Link-Inline-light-tritanopia-hover-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.