AnchoredOverlay: Add Popover API, modifications to CSS anchor positioning#7677
Draft
AnchoredOverlay: Add Popover API, modifications to CSS anchor positioning#7677
Conversation
🦋 Changeset detectedLatest commit: 6686023 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
staff
Contributor
|
TylerJDev
force-pushed
the
tylerjdev/add-popover-support-css-anchor-positioning
branch
from
b2ee25e to
b55ac54
Compare
Contributor
|
🤖 Lint issues have been automatically fixed and committed to this PR. |
TylerJDev
changed the title
TylerJDev
force-pushed
the
tylerjdev/add-popover-support-css-anchor-positioning
branch
from
69db3ec to
1c6dadf
Compare
TylerJDev
added
the
update snapshots
github-actions
bot
removed
the
update snapshots
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/16925 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite to https://github.com/github/primer/issues/6448, part of https://github.com/github/primer/issues/6431
Utilizes the Popover API to power our CSS anchor positioning in
AnchoredOverlay. Both the popover support and CSS anchor positioning are behind theprimer_react_css_anchor_positioningfeature flag.Changelog
New
AnchoredOverlayChanged
Rollout strategy
Testing & Reviewing
Merge checklist