Conversation
🦋 Changeset detectedLatest commit: d95cfdf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Pull request overview
Adds an archived status to the StateLabel component so consumers can render an “Archived” state with appropriate iconography, styling, and Storybook/docs coverage (per primer/#6478).
Changes:
- Extends
StateLabelwith a newstatus="archived"option (Archive icon + accessible label). - Adds
archivedstyling in the CSS module and wires it into Storybook/Figma/docs metadata. - Updates unit tests and snapshots to cover the new status.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/StateLabel/StateLabel.tsx | Adds archived to the status/icon map and label map (aria-label). |
| packages/react/src/StateLabel/StateLabel.module.css | Adds visual styling for [data-status='archived']. |
| packages/react/src/StateLabel/StateLabel.features.stories.tsx | Adds a Storybook “Archived” example. |
| packages/react/src/StateLabel/StateLabel.figma.tsx | Exposes archived in the Figma Code Connect status enum (pull request variant). |
| packages/react/src/StateLabel/StateLabel.docs.json | Updates docs metadata: story id + status union type includes archived. |
| packages/react/src/StateLabel/tests/StateLabel.test.tsx | Adds test coverage for rendering and aria-label/text for archived. |
| packages/react/src/StateLabel/tests/snapshots/StateLabel.test.tsx.snap | Adds snapshot for status="archived". |
lukasoppermann
left a comment
There was a problem hiding this comment.
LGTM form the design side. 👍
|
@siddharthkp I'm not sure why the CI job keeps failing but the errors look unrelated to the changes. Also, the earlier integration test PR had passed on all checks: https://github.com/github/github-ui/pull/16508#issuecomment-4093408899. Can we skip these checks? |
|
Yeah doesn't seem related to your changes at all. Might be a flakey test in github-ui. Can you please confirm by running the tests in a codespace for the integration branch (https://github.com/github/github-ui/pull/16691) If it's passing, then you can use the label |
|
Actually it is failing in the codespace too 😅. I found a thread related to the error: https://github.slack.com/archives/C095A1FSPFW/p1774288253128469. It looks like a fix for it will be going out soon: https://github.com/github/github-ui/pull/16736 |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/16818 |
Closes # https://github.com/github/primer/issues/6478
Changelog
New
Add 'archived' status to StateLabel component
Rollout strategy
Testing & Reviewing
Merge checklist