Skip to content

Add a mcp.json config and configuring mcp servers for GitHub Primer and Playwright#7694

Open
jonrohan wants to merge 1 commit intomainfrom
add_mcp_servers
Open

Add a mcp.json config and configuring mcp servers for GitHub Primer and Playwright#7694
jonrohan wants to merge 1 commit intomainfrom
add_mcp_servers

Conversation

@jonrohan
Copy link
Member

Adding .vscode/mcp.json config to the repository with playwright, github, and primer mcp servers configured.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; This has to do with dev experience more than the library

Merge checklist

@jonrohan jonrohan added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels Mar 23, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2026

⚠️ No Changeset found

Latest commit: 414c23e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohan jonrohan marked this pull request as ready for review March 23, 2026 21:39
@jonrohan jonrohan requested a review from a team as a code owner March 23, 2026 21:39
@github-actions github-actions bot added the staff Author is a staff member label Mar 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a VS Code MCP configuration to the repo to enable shared MCP server setup (GitHub Copilot MCP, Playwright MCP, and Primer MCP) as part of contributor dev experience, and updates gitignore so the config can be checked in.

Changes:

  • Add .vscode/mcp.json defining MCP servers for github, playwright, and primer.
  • Stop ignoring .vscode in .gitignore so the MCP config (and other workspace configs) can be committed.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
.vscode/mcp.json Introduces shared MCP server configuration for VS Code.
.gitignore Removes .vscode from ignored paths to allow committing the MCP config.

Comment on lines +7 to +13
"playwright": {
"command": "npx",
"args": [
"-y",
"@microsoft/mcp-server-playwright"
]
},
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The playwright MCP server entry is missing a type field. Our own @primer/mcp README’s VS Code example config specifies type: "stdio" for command-based servers; without it, VS Code may not treat this server as a stdio MCP server and fail to start it. Add "type": "stdio" to the playwright server config for consistency and to match the documented schema.

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +3
{
"servers": {
"github": {
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root MCP config omits the inputs field (the @primer/mcp README’s VS Code example includes "inputs": []). If VS Code expects this key (even as an empty array), the config may be considered incomplete or get rewritten by tooling. Consider adding "inputs": [] at the root for compatibility with the documented configuration shape.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants