fix(site): DR-7903 remove Optimize section from pricing page#7721
fix(site): DR-7903 remove Optimize section from pricing page#7721ArthurGamby wants to merge 1 commit intomainfrom
Conversation
WalkthroughReformatted type definitions and function signatures for improved readability, consolidated FAQ string literals with quote style normalization, and updated pricing comparison data by removing the "Database optimizations" section entry and restructuring the "Cache tag invalidations" row. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/site/src/app/pricing/pricing-data.ts (1)
160-197: Add a small regression test for removed comparison sections.To prevent accidental reintroduction, add a test asserting that
comparisonSectionsdoes not include"Database optimizations"and that expected section titles remain present.✅ Example test shape
+import { comparisonSections } from "./pricing-data"; + +describe("pricing comparison sections", () => { + it('does not include "Database optimizations"', () => { + const titles = comparisonSections.map((s) => s.title); + expect(titles).not.toContain("Database optimizations"); + }); +});🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/site/src/app/pricing/pricing-data.ts` around lines 160 - 197, Add a regression test for the exported constant comparisonSections that asserts the array of section titles does not include "Database optimizations" and that the expected titles in the diff ("Managed Connection Pool", "Global Cache", "Data management", "Platform") are present; locate the constant comparisonSections in the module and write a unit test that imports it, maps comparisonSections to their title strings, checks titleList.includes for each expected title, and asserts titleList.includes("Database optimizations") is false (or uses a negative assertion) to fail if the removed section is reintroduced.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/site/src/app/pricing/pricing-data.ts`:
- Around line 160-197: Add a regression test for the exported constant
comparisonSections that asserts the array of section titles does not include
"Database optimizations" and that the expected titles in the diff ("Managed
Connection Pool", "Global Cache", "Data management", "Platform") are present;
locate the constant comparisonSections in the module and write a unit test that
imports it, maps comparisonSections to their title strings, checks
titleList.includes for each expected title, and asserts
titleList.includes("Database optimizations") is false (or uses a negative
assertion) to fail if the removed section is reintroduced.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 634eea67-b002-45bf-adba-18616b726ac0
📒 Files selected for processing (1)
apps/site/src/app/pricing/pricing-data.ts
|
Wrong repo — this ticket is for the website repo, not web. |
Summary
comparisonSectionsinpricing-data.tsLinear
https://linear.app/prisma-company/issue/DR-7903/remove-optimize-section-from-the-pricing-page
Test plan
/pricingSummary by CodeRabbit