Open
Conversation
Rebuild the TypedSQL page from the old website into the new apps/site with ORM color scheme, CardSection blocks, YouTube embed, and Card+Action expand section. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Left-align the TypedSQL CTA links and swap in a supported icon so the capabilities card renders correctly. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughAdds a TypedSQL landing page and two supporting UI components (video and capabilities), and updates the sitemap to include the new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/site/src/components/typedsql/video-section.tsx (1)
1-1: Consider removing"use client"— this component has no client-side interactivity.This component renders static JSX with an iframe. It doesn't use any React hooks, event handlers, or browser APIs that would require client-side JavaScript. Removing the directive allows Next.js to render it as a Server Component, reducing the client bundle size.
♻️ Suggested change
-"use client"; - export const VideoSection = () => {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/site/src/components/typedsql/video-section.tsx` at line 1, Remove the "use client" directive at the top of the video-section component so it can be a Next.js Server Component; locate the top of apps/site/src/components/typedsql/video-section.tsx (the module that currently only renders static JSX with an iframe and exports the component) and delete the "use client" line, then verify there are no client-only hooks or browser API usages in the component (e.g., no useState/useEffect or event handlers) so it can safely be server-rendered.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/site/src/components/typedsql/video-section.tsx`:
- Line 1: Remove the "use client" directive at the top of the video-section
component so it can be a Next.js Server Component; locate the top of
apps/site/src/components/typedsql/video-section.tsx (the module that currently
only renders static JSX with an iframe and exports the component) and delete the
"use client" line, then verify there are no client-only hooks or browser API
usages in the component (e.g., no useState/useEffect or event handlers) so it
can safely be server-rendered.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6cfb5b62-aa07-4005-9401-66d71ad5dc64
⛔ Files ignored due to path filters (6)
apps/site/public/illustrations/typedsql/end-to-end-type-safety.svgis excluded by!**/*.svgapps/site/public/illustrations/typedsql/end-to-end-type-safety_light.svgis excluded by!**/*.svgapps/site/public/illustrations/typedsql/full-controll-sql.svgis excluded by!**/*.svgapps/site/public/illustrations/typedsql/full-controll-sql_light.svgis excluded by!**/*.svgapps/site/public/illustrations/typedsql/great-dx.svgis excluded by!**/*.svgapps/site/public/illustrations/typedsql/great-dx_light.svgis excluded by!**/*.svg
📒 Files selected for processing (4)
apps/site/src/app/sitemap.tsapps/site/src/app/typedsql/page.tsxapps/site/src/components/typedsql/expand-capabilities.tsxapps/site/src/components/typedsql/video-section.tsx
…round Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/site/src/app/typedsql/page.tsx`:
- Around line 144-146: The wrapper div around CardSection uses "w-screen" which
can cause horizontal overflow; change the className on the div rendering
CardSection (the element wrapping CardSection and twoCol) to use "w-full"
instead of "w-screen" so the container respects parent width and avoids 100vw
scrollbar issues; update the JSX where CardSection and twoCol are passed to
reflect this class change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fd2cf037-1d03-4ac8-bf56-c83d4f68f792
📒 Files selected for processing (1)
apps/site/src/app/typedsql/page.tsx
Comment on lines
+144
to
+146
| <div className="w-screen"> | ||
| <CardSection cardSection={twoCol} /> | ||
| </div> |
Contributor
There was a problem hiding this comment.
Prefer w-full over w-screen to avoid horizontal overflow
Line 144 can cause subtle horizontal scrollbars (100vw includes scrollbar width). w-full is safer in page containers.
💡 Proposed fix
- <div className="w-screen">
+ <div className="w-full">
<CardSection cardSection={twoCol} />
</div>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <div className="w-screen"> | |
| <CardSection cardSection={twoCol} /> | |
| </div> | |
| <div className="w-full"> | |
| <CardSection cardSection={twoCol} /> | |
| </div> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@apps/site/src/app/typedsql/page.tsx` around lines 144 - 146, The wrapper div
around CardSection uses "w-screen" which can cause horizontal overflow; change
the className on the div rendering CardSection (the element wrapping CardSection
and twoCol) to use "w-full" instead of "w-screen" so the container respects
parent width and avoids 100vw scrollbar issues; update the JSX where CardSection
and twoCol are passed to reflect this class change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
apps/site/src/app/typedsql/page.tsxfor lint issuesapps/site/src/components/typedsql/expand-capabilities.tsxfor lint issues/typedsqlMade with Cursor
Summary by CodeRabbit