Improvements#8
Merged
Merged
Conversation
…cing offset update: Changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
_defaultBufferSize→_initialBufferSizer(and parameterdefaultBufferSize→initialBufferSizerinacquire()andwithWriter())New Features:
_discardedPoolFullcounter — tracks writers discarded due to pool full (max 32)_varIntSize(int value)— helper function for VarInt size calculation (switch expression)peekByte()— returns byte at current position without advancing offsetBinaryReader.fromList(List<int>)— convenient constructor forList<int>Fixes:
initialBufferSizerinacquire()— throwsRangeErrorfor invalid size_initializeBuffer()now resets_isInPool = false, correcttakeBytes()→release()flow for pooled writersclear()now resets_isInPoolfor pooled writerslatefrom_ReaderStateand_WriterState(offset, capacity, list)peekBytes()(already guarded by_checkBounds)Refactoring:
_validated→_fromSize@param/@returnwith Dart style (Parameters:/Returns:)Tests: