Skip to content

chore: update @probelabs/probe to v0.6.0-rc247 #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
probelabs wants to merge 1 commit into from
Closed

chore: update @probelabs/probe to v0.6.0-rc247 #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"@octokit/auth-app": "^8.1.0",
"@octokit/core": "^7.0.3",
"@octokit/rest": "^22.0.0",
"@probelabs/probe": "^0.6.0-rc245",
"@probelabs/probe": "^0.6.0-rc247",

Check warning on line 105 in package.json

View check run for this annotation

probelabs / Visor: architecture

architecture Issue 

Using caret (^) versioning with pre-release software allows automatic updates to newer release candidates, which may introduce breaking changes. Consider pinning to exact version for pre-release dependencies.
Raw output 
Consider using exact version pinning for pre-release dependencies: "@probelabs/probe": "0.6.0-rc247" instead of "@probelabs/probe": "^0.6.0-rc247" to prevent automatic updates to potentially incompatible rc versions.

Check warning on line 105 in package.json

View check run for this annotation

probelabs / Visor: architecture

architecture Issue 

Dependency update from rc245 to rc247 lacks changelog review documentation. The codebase has a WORKAROUND comment in tracer-init.ts indicating the probe API is evolving, making changelog review important.
Raw output 
Review the @probelabs/probe changelog between v0.6.0-rc245 and v0.6.0-rc247 to identify any breaking changes, especially related to SimpleAppTracer, SimpleTelemetry, or the recordEvent method mentioned in the WORKAROUND at visor/src/utils/tracer-init.ts:75-78.

Check warning on line 105 in package.json

View check run for this annotation

probelabs / Visor: quality

testing Issue 

Dependency update from @probelabs/probe v0.6.0-rc245 to v0.6.0-rc247 lacks integration test coverage with the actual dependency. The existing tests in tests/unit/mermaid-escaping-test.test.ts and tests/unit/mermaid-production-scenario.test.ts use jest.mock() to mock the ProbeAgent class, which means they won't catch breaking API changes in the updated dependency. While tests/e2e/mcp-probe-e2e.test.ts does execute the actual binary via npx, it only tests the MCP transport interface, not the direct ProbeAgent SDK usage in src/ai-review-service.ts.
Raw output 
Add an integration test that imports and instantiates the actual @probelabs/probe ProbeAgent class (not mocked) to verify basic API compatibility after dependency updates. This test should call initialize() and a simple answer() method to ensure the SDK interface hasn't changed in a breaking way. Consider adding this to a new tests/integration/probe-sdk-integration.test.ts file.

Check warning on line 105 in package.json

View check run for this annotation

probelabs / Visor: quality

testing Issue 

Transitive dependency @probelabs/maid updated from 0.0.24 to 0.0.25 as part of the @probelabs/probe update. While this is typically safe, there is no test coverage that verifies this transitive dependency's functionality. The codebase imports from @probelabs/probe but @probelabs/maid is a dependency of that package, so changes could affect behavior.
Raw output 
Review the changelog for @probelabs/maid v0.0.25 to identify any breaking changes or behavioral modifications. If @probelabs/maid's API affects your code's behavior (e.g., through DelegationManager or other exported types), consider adding tests that verify the expected behavior after the update.

Check notice on line 105 in package.json

View check run for this annotation

probelabs / Visor: quality

architecture Issue 

The dependency uses a release candidate version (^0.6.0-rc247). While this is intentional for testing pre-release features, it carries higher risk than stable releases. The automated update from rc245 to rc247 suggests frequent changes in the RC series.
Raw output 
Consider pinning to a specific RC version (remove the ^) if you need strict control over which RC is used, or document why this RC series is acceptable for production use. Monitor the @probelabs/probe repository for the stable 0.6.0 release and plan to upgrade once available.
"@types/commander": "^2.12.0",
"@types/uuid": "^10.0.0",
"ajv": "^8.17.1",
Expand Down
Loading