[fix] added username and password in url for remote http#96
Open
imantoniojuan wants to merge 1 commit intoproconsule:masterfrom
Open
[fix] added username and password in url for remote http#96imantoniojuan wants to merge 1 commit intoproconsule:masterfrom
imantoniojuan wants to merge 1 commit intoproconsule:masterfrom
Conversation
Author
|
Realised that on top of this, network via http also does not work. I tried bypassing my domain and connect via local network, it still fails show the file listing and only show local files. Enabling DB causes the app to crash when connecting. (v0.9.0) |
|
basic http authorisation? good job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, I am unable to reach my own web server with auth. I checked the code and found that the user and password were not being included in the curl path. I have added a check if those variables are not null and will be appended to the curl path.